Fix point tooltip shared #3511
Closed
Fix point tooltip shared #3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1014675773
💛 - Coveralls |
visiky
reviewed
Jul 12, 2021
| shapes.push((child as IGroup).getShape(x, y, ev)); | ||
| } else if ((child as IShape).isHit(x, y)) { | ||
| shapes.push(child); | ||
| } |
There was a problem hiding this comment.
这里直接参考了 g-base包src/abstract/container.ts/getShape方法
There was a problem hiding this comment.
之前是调用g-base的getShape方法，返回对应鼠标位置的shape（只返回单个）,我就参照g-base，返回了对应鼠标位置的所有shapes，然后，因为返回的shape[]是个数组，就对g2/src/util/tooltip.ts稍微做了些改造，所有的改造基本都是基于老逻辑的
|
@hustcc tooltip 默认只展示捕获到的最近的数据点（一个），这里处理了之后，就是把所有命中 🎯 的点获取到 但我觉得 shared 的话，应该是从数据上有一个关联关系去获取到，而不是这里的获取所有 hit points，你有其它解法吗 |
|
没有太看懂逻辑，这个 pr 是修复哪一个 issue 的？ |
2 tasks
我也没看懂逻辑，你看下 issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change
修复散点图存在多个点在同一位置下，开启shared无反应