Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): fail to identify annotation as mark (close: #4106) #4109

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

pearmini
Copy link
Member

See #4106 for more detail.

G2.render({
  type: 'layer',
  children: [
    {
      type: 'interval',
      coordinate: [{ type: 'theta', innerRadius: 0.5 }],
      scale: { color: { guide: null } },
      data: [
        { genre: 'Sports', sold: 275 },
        { genre: 'Strategy', sold: 115 },
        { genre: 'Action', sold: 120 },
        { genre: 'Shooter', sold: 350 },
        { genre: 'Other', sold: 150 },
      ],
      encode: {
        y: 'sold',
        color: 'genre',
      },
    },
    {
      type: 'annotation.text',
      data: [{ x: 0.5, y: 0.5, text: 'G2' }],
      scale: {
        x: { guide: null },
        y: { guide: null },
      },
      encode: {
        x: 'x',
        y: 'y',
        text: 'text',
        color: 'black',
      },
      style: {
        fontSize: 60,
        textBaseline: 'middle',
        fontWeight: 'bold',
      },
    },
  ],
})

@pearmini pearmini added the Bug label Aug 23, 2022
@pearmini pearmini added this to the 5.0.0-alpha.1 milestone Aug 23, 2022
@pearmini pearmini self-assigned this Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants