feat(component): support slider without interaction #4413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
文档我晚上来补吧 |
discussion中已经把文档写好了，只缺配置项部分而已 |
pearmini
reviewed
Dec 6, 2022
pearmini
requested changes
Dec 6, 2022
pr-triage
bot
added
PR: reviewed-changes-requested
PR: unreviewed
and removed
PR: unreviewed
PR: reviewed-changes-requested
labels
✅ transpose 下的 slider 待办:
|
|
还有一个问题，就是 Chart API 也需要更新一下？ |
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
pearmini
requested changes
Dec 7, 2022
pr-triage
bot
added
PR: reviewed-changes-requested
PR: unreviewed
and removed
PR: unreviewed
PR: reviewed-changes-requested
labels
hustcc
approved these changes
Dec 7, 2022
Closed
hustcc
pushed a commit
that referenced
this pull request
May 16, 2023
* feat(component): support slider without interaction * fix(slider): code review suggestions * feat(slider): support transposed slider * feat: add slider api * feat(slider): support band scale & add slider docs * fix: lint * test: add slider chart api test case
hustcc
pushed a commit
that referenced
this pull request
May 16, 2023
* feat(component): support slider without interaction * fix(slider): code review suggestions * feat(slider): support transposed slider * feat: add slider api * feat(slider): support band scale & add slider docs * fix: lint * test: add slider chart api test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
详情见: #4396