Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): api 跳转部分修复 #5352

Merged
merged 2 commits into from
Jul 27, 2023
Merged

fix(api): api 跳转部分修复 #5352

merged 2 commits into from
Jul 27, 2023

Conversation

ai-qing-hai
Copy link
Collaborator

  • 修复跳转链接名称错误的问题 （ 例如 /spec/mark/lineX 需要改为 /spec/mark/line-x ）
  • 修复跳转链接位置错误的问题 （ 例如 /spec/mark/sankey 需要改为 /spec/graph/sankey ）

fixed: #5295

@pearmini
Copy link
Member

以后 PR 的 title 和 commit 的描述尽量有英文哈 😄！

@pearmini pearmini merged commit 66c58af into v5 Jul 27, 2023
2 of 3 checks passed
@pearmini pearmini deleted the fix-v5-link branch July 27, 2023 11:53
@ai-qing-hai
Copy link
Collaborator Author

@pearmini 上面的还有 4 个左右文档缺失不能跳转的，我在代码上标出来了。

@pearmini
Copy link
Member

@pearmini 上面的还有 4 个左右文档缺失不能跳转的，我在代码上标出来了。

具体在哪里标出来了？我咋没看见😭

@pearmini pearmini mentioned this pull request Jul 28, 2023
Merged
@ai-qing-hai
Copy link
Collaborator Author

@pearmini
chart.zh.md 文件
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearmini pearmini pearmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v5文档跳转异常
2 participants
@ai-qing-hai @pearmini