Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie): interaction for composite mark #5524

Merged
merged 1 commit into from Sep 11, 2023
Merged

fix(pie): interaction for composite mark #5524

merged 1 commit into from Sep 11, 2023

Conversation

pearmini
Copy link
Member

fix: #5463

  • 复合 mark 交互失效:修改 options 的 marks 为转换过后的 marks
  • pie 没有动画的时候会飞出去:G 里面的一个 bug, 更新 tranform 之前需要设置为空,G2 先做处理
// 不会生效
path.style.transform = 'translate(10, 10)';
path.style.transform = 'translate(20, 20)';
// 生效
path.style.transform = 'translate(10, 10)';
path.style.transform = ''; // 这一行不能缺
path.style.transform = 'translate(20, 20)';

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6141594048

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 88.474%

Totals Coverage Status
Change from base Build 6106698679: 0.006%
Covered Lines: 9849
Relevant Lines: 10777

💛 - Coveralls

@pearmini pearmini merged commit ae3138c into v5 Sep 11, 2023
3 checks passed
@pearmini pearmini deleted the fix/pie-interaction branch September 11, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

composite mark 交互不生效
3 participants