Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 去除双轴图默认meta设置 #2004

Closed
wants to merge 1 commit into from

Conversation

liuzhenying
Copy link
Member

@liuzhenying liuzhenying commented Nov 24, 2020

原因:
上个版本和柱线图保持一致,x 轴的 scale 默认设置为 ‘cat’ 类型。
但双轴图的 cat 类型,在某一方有空数据的情况下,会导致渲染错误,(见示例 https://riddle.alibaba-inc.com/riddles/7245c531 粗略看了眼,是 g2 在 syncScale 时,cat类型的时候两个 x 轴的排序没有对上。我再看下是在 g2 上修还是 g2 plot 上修)
这个 pr 先去除掉这个默认设置,随后再 fix cat 分类问题

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2020

😭 Deploy PR Preview 609d872 failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

Pull Request Test Coverage Report for Build 380841340

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.59%

Totals Coverage Status
Change from base Build 380228559: 0.0%
Covered Lines: 3948
Relevant Lines: 3986

💛 - Coveralls

@liuzhenying liuzhenying reopened this Nov 25, 2020
@hustcc
Copy link
Member

hustcc commented Nov 25, 2020

@liuzhenying 默认分类的问题是啥?如果不默认分类,又会有其他问题。

@liuzhenying
Copy link
Member Author

@liuzhenying 默认分类的问题是啥?如果不默认分类,又会有其他问题。

目前 time 分类存在的问题:1. 存在空数据 2. 某个 data 为空时,坐标问题,如下图

屏幕快照 2020-11-25 12 14 29

cat 分类存在的问题:某个数据项为空时,渲染错位(应该是 sync 时排序使得两个 view 的坐标顺序不同了,又因为双轴图只显示了左 view x 坐标,使得看上去错位了)

提这个 pr,是觉得默认 cat 的问题,比默认 time 的问题更严重,顺车先回滚下,并不能解决上述问题。不过我先关掉好了,这两天直接修 bug 吧

@hustcc hustcc deleted the fix/dual-default-meta branch February 24, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants