Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue#4552, another 404 not found and typo errors #4554

Merged

Conversation

zqqcee
Copy link
Contributor

@zqqcee zqqcee commented May 31, 2023

Checklist
  • [ x] commit message follows commit guidelines
Description of change

(一)在文档发现几处Demo的URL点击报错404,此PR解决中文与英文文档中的404 not found 错误。经过查看example,发现这个错误是由于URL中没有加上锚点“#”导致的。根据example中的对应地址修改了几处URL。
修改了以下pages:

  1. /manual/middle/elements/combos/default-combo
  2. /api/items/combo-methods
  3. /api/items/edge-methods
  4. /api/items/node-methods

(二)在以下pages中发现有几处笔误,已修改

  1. /api/items/combo-methods。将自定义节点与内置节点修改为自定义Combo与内置Combo
  2. /api/items/edge-methods。 将自定义节点修改为自定义边
    经查阅,仅中文文档出现错误,英文文档无误。

@zqqcee zqqcee changed the title Fix issue#4552 Fix issue#455, another 404 and typo errors May 31, 2023
@zqqcee zqqcee changed the title Fix issue#455, another 404 and typo errors Fix issue#4552, another 404 and typo errors May 31, 2023
@zqqcee zqqcee changed the title Fix issue#4552, another 404 and typo errors Fix issue#4552, another 404 not found and typo errors May 31, 2023
@Yanyan-Wang
Copy link
Contributor

非常感谢你的 PR!❤️

@Yanyan-Wang Yanyan-Wang changed the base branch from master to 4.8.15 June 5, 2023 08:03
@Yanyan-Wang Yanyan-Wang merged commit 6968bed into antvis:4.8.15 Jun 5, 2023
4 checks passed
Yanyan-Wang added a commit that referenced this pull request Jun 5, 2023
* fix: combo animate is not activated with createCombo;

* Fix issue#4552, another 404 not found and  typo errors (#4554)

* fix: Fix the issue#4552 both in en-document and cn-document

* fix: Fix the 404 error in "/api/items/combo-methods" and "api/items/node-methods" and "/api/items/edge-methods" The demo URL of these pages is not valid. I added a "#" tag after URL

* fix: 文档中此处有错误,将此处的内置节点改为内置combo

* fix:文档此处有误,将此处的自定义节点改为自定义边

* fix: layout url (#4529)

---------

Co-authored-by: zqqcee <55946653+zqqcee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants