fix: "Node not found" error from 'getNode()' #4608
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm test
passesDescription of change
undo delete workflow
To fix the bug Node not found, I've changed packages/g6/src/runtime/controller/item.ts
old version:
new version:
Why this change
For the bug Node not found mentioned before
An error is throwed from this function 'getNode()'; msg: "Node not found for id: 1"
After testing, I found that 'id' variable is always string after
Object.keys(update).forEach((id)=>{...})
, but one in user data is number, possibly.I tried adding a
try-catch
block to fix this bug, Now:string
andnumber
types of idThis PR is modified from #4599
try-catch
to solves the bug : "Node not found for id"The test demo located in here: packages/g6/tests/intergration/bugReproduce.ts