feat: migrating bundling plugin to v5 #5116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
可以加一下效果截图吗 |
Yanyan-Wang
reviewed
Nov 8, 2023
| } | ||
|
|
||
| if (self.ticking) { | ||
| self.ticking = false; |
There was a problem hiding this comment.
这个好像没有看到哪里设置 true 的～ 可能和之前正在布局的判断方式不同了
There was a problem hiding this comment.
这块我先去掉了，在 master 和 v5 分支上的 layoutController 上没有找到相关的代码，在其他插件里也没有看到有类似逻辑的，如果有其他方式可以跟我说下大概的位置，我再改下。
|
|
relative issuehunt issue: #4583 |
|
麻烦补充一下对应的文档呢，位于 |
|
|
|
@Aarebecca 后续调整改好了，有空了瞅下。 |
Aarebecca
approved these changes
Dec 8, 2023
|
你好，这个 PR 先合并了，后续期望能够提供一个官网的 Demo ～ 🎉 |
Merged
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change
fix #4583
原来的 options
onTick和onLayoutEnd没有添加，目前还不清楚这两个函数的触发条件，看4.x的文档 https://g6.antv.antgroup.com/en/manual/middle/plugins/plugins#edge-bundling 中也没有提到这两个，帮忙确认下是否需要添加和调整。