-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrating bundling plugin to v5 #5116
Conversation
可以加一下效果截图吗 |
} | ||
|
||
if (self.ticking) { | ||
self.ticking = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个好像没有看到哪里设置 true 的~ 可能和之前正在布局的判断方式不同了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这块我先去掉了,在 master 和 v5 分支上的 layoutController 上没有找到相关的代码,在其他插件里也没有看到有类似逻辑的,如果有其他方式可以跟我说下大概的位置,我再改下。
relative issuehunt issue: #4583 |
麻烦补充一下对应的文档呢,位于 |
|
@Aarebecca 后续调整改好了,有空了瞅下。 |
你好,这个 PR 先合并了,后续期望能够提供一个官网的 Demo ~ 🎉 |
ok |
Checklist
npm test
passesDescription of change
fix #4583
原来的 options
onTick
和onLayoutEnd
没有添加,目前还不清楚这两个函数的触发条件,看4.x的文档 https://g6.antv.antgroup.com/en/manual/middle/plugins/plugins#edge-bundling 中也没有提到这两个,帮忙确认下是否需要添加和调整。