feat: add star node #5410
Merged
feat: add star node #5410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hustcc
commented
Feb 1, 2024
•
hustcc
commented
- fixed [v5] 增加 node 类型 star 组件 #5400
- star node
- test cases
yvonneyx
reviewed
Feb 2, 2024
This was referenced Feb 2, 2024
Aarebecca
reviewed
Feb 2, 2024
| /** | ||
| * 内半径 | ||
| */ | ||
| innerR: number; |
There was a problem hiding this comment.
节点之间的配置项差异太大了，后面不太方便统一处理，base-node节点尺寸使用 width 和 height 表示吧，Circle 的 r 和这里的outerR就是取 min(width, height) / 2, innerR 应该可以按外半径比例计算出一个默认值，也可以用户指定
There was a problem hiding this comment.
innerR 可以做成可选，默认就是正常的五角星，看图中第一个，是一个变种的五角星，看是否需要保留。
后面峰值统一对共同属性就行处理吧。
Aarebecca
reviewed
Feb 2, 2024
| ], | ||
| // anchor | ||
| anchorOptions: [ | ||
| { position: 'left', r: 2, stroke: 'black', lineWidth: 1, zIndex: 2 }, |
There was a problem hiding this comment.
我后面一个分支单独对样式进行优化吧，这个分支先简单一些，也给开发者一个参考。
hustcc
force-pushed
the
feat-star-node
branch
from
0a3961c
to
66ae7db
Compare
Aarebecca
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.