New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adapt combo, add drag-element / collapse-expand behaviors #5543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aarebecca
force-pushed
the
refactor/fit-combo-2
branch
from
March 15, 2024 07:39
556217f
to
687e4be
Compare
hustcc
reviewed
Mar 15, 2024
* | ||
* <en/> Callback when expand is completed | ||
*/ | ||
onexpand?: (id: ID) => void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
驼峰。
hustcc
reviewed
Mar 15, 2024
packages/g6/src/themes/light.ts
Outdated
@@ -179,6 +178,8 @@ export const light: Theme = { | |||
enter: 'fade', | |||
exit: 'fade', | |||
visibility: 'fade', | |||
expand: 'combo-collapse-expand', | |||
collapse: 'combo-collapse-expand', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
后面去掉依赖关系。
hustcc
approved these changes
Mar 15, 2024
Aarebecca
force-pushed
the
refactor/fit-combo-2
branch
from
March 15, 2024 16:13
687e4be
to
ce8eab5
Compare
Aarebecca
changed the title
feat: adapt combo, add drag-element / collapse-expan behaviors
feat: adapt combo, add drag-element / collapse-expand behaviors
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
适配 Combo
DragElement
CollapseExpand
待办
DragElement
Behavior to drag comboCollapseExpand
Behavior that can collapse / expand combo by double clickTodo