New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add plugin contextmenu #5577
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aarebecca
reviewed
Mar 22, 2024
Aarebecca
reviewed
Mar 22, 2024
@@ -0,0 +1,62 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我在想后面类似的方法放到所在的模块里就可以了, utils 里放多个模块都会用到的方法。目前都是放在 utils
里后面可能会很大。类型定义也同理
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯,是的,或者跟之前一样,把一个插件做成目录而不是一个文件,然后里面就可以自己组织了。
hustcc
force-pushed
the
feat-plugin-context-menu
branch
from
March 22, 2024 09:45
64dab8d
to
38a31b9
Compare
hustcc
force-pushed
the
feat-plugin-context-menu
branch
from
March 22, 2024 10:14
38a31b9
to
d09a70d
Compare
Aarebecca
reviewed
Mar 22, 2024
todo
|
Aarebecca
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
之前的配置项见这里,新的配置项如下:
主要改动点: