refactor: focus-element, lasso-select, brush-select behavior #5707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aarebecca
reviewed
May 7, 2024
packages/g6/__tests__/snapshots/behaviors/lasso-select/lasso-selecting-3.svg
Outdated
Show resolved
Hide resolved
|
除注释外主要还涉及哪些方面的改动呢 |
看下 lasso 和 brush，改动有点多，完善了下功能 |
|
覆盖率跌得有点多，可能得补下用例了，我看主要集中在 |
yvonneyx
force-pushed
the
refactor/behavior-focus
branch
from
c0ab9e4
to
d8a0e8a
Compare
yvonneyx
force-pushed
the
refactor/behavior-focus
branch
from
d8a0e8a
to
9e0bbae
Compare
Aarebecca
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.