Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): fix incorrect combo connect #5726

Merged
merged 2 commits into from
May 11, 2024
Merged

fix(runtime): fix incorrect combo connect #5726

merged 2 commits into from
May 11, 2024

Conversation

Aarebecca
Copy link
Contributor

基于 / Based on: #5725

  • 修复连接到收起的 combo 内的子节点时,边更新异常的问题

  • Fixed an exception in edge update when connecting to a child node in a collapsed combo

else break;
}
if (path.some((n) => n.style?.collapsed)) {
const index = path.findLastIndex((n) => n.style?.collapsed);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用了 findLastIndex 语法,所以要求 node 版本 >= 18,否则本地测试无法执行

@hustcc hustcc merged commit 3659e7d into v5 May 11, 2024
5 checks passed
@hustcc hustcc deleted the fix/combo branch May 11, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants