fix: fix the conflict issue of hover-element and drag-element #5762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvonneyx
changed the title
Aarebecca
reviewed
May 22, 2024
|
|
||
| const canvas = this.context.canvas.document; | ||
| canvas.addEventListener(`${CommonEvent.DRAG_START}`, this.toggleFrozen); | ||
| canvas.addEventListener(`${CommonEvent.DRAG_END}`, this.toggleFrozen); | ||
| } |
There was a problem hiding this comment.
一个小问题，根据事件参数来设置 flag 会比 toggle 更稳定些，一些极端情况下这两个事件可能并不会成对触发
yvonneyx
force-pushed
the
fix/behavior-collision
branch
from
4fd4657
to
08db398
Compare
Aarebecca
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hover-element和drag-element交互共用时冲突问题npm run doc:dev支持本地生成api文档（由于 reference 文件过多，dumi启动慢，本地先删除 reference）