Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix site docs #5897

Merged
merged 4 commits into from
Jun 21, 2024
Merged

docs: fix site docs #5897

merged 4 commits into from
Jun 21, 2024

Conversation

codersjj
Copy link
Contributor

No description provided.

@Aarebecca
Copy link
Contributor

Aarebecca commented Jun 20, 2024

建议使用如下写法:/ The following is recommended:

const { Graph } = G6;

// ...

我们并不推崇 G6.Graph 的写法,当然在 UMD 下这种写法是无所谓的,但通过 Module 引入时会导致无法进行 TreeShaking

We don't recommend 'G6.Graph', of course it doesn't matter under UMD, but it doesn't work when introduced via Module

@codersjj
Copy link
Contributor Author

建议使用如下写法:/ The following is recommended:

const { Graph } = G6;

// ...

我们并不推崇 G6.Graph 的写法,当然在 UMD 下这种写法是无所谓的,但通过 Module 引入时会导致无法进行 TreeShaking

We don't recommend 'G6.Graph', of course it doesn't matter under UMD, but it doesn't work when introduced via Module

Allright! I've updated the code.

@Aarebecca Aarebecca merged commit 33047a8 into antvis:v5 Jun 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants