fix: 修复 bindings 缓存在 WebGPU 的问题 #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8f12ee2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2 tasks
xiaoiver
approved these changes
Jun 7, 2024
Merged
lvisei
added a commit
that referenced
this pull request
Jun 11, 2024
* refactor: 重构高德地图 V2 以视口进行同步 (#2387) * refactor: amap next * fix: getMinZoom * refactor: base map * fix: source update 事件访问图层初始化未完成 * fix: 新版高德大于 21 级别抖动问题 * fix: Mapbox/Maplibre 20 层级以上数据偏移问题 (#2416) * fix: fix line data offset in mapbox * refactor: 完成点线面图层属性索引重构 * refactor: 完成 citybuliding\earth\geometry\heatmap 图层属性索引重构 * refactor: 完成 image/ raster/wind 图层属性索引重构 * refactor: 标记最大索引 * fix: line layer data shake * refactor: 自定义开启双精度属性 * fix: map type * fix: amap support three * refactor: 移除不必要的剔除逻辑 * fix: 修复面图层光照计算 * fix: type EventEmitter * fix: mapbox 下部分面数据图层绘制异常 (#2453) * fix: mapbox 下部分面数据图层绘制异常 * fix: 3d extrude polygon layer * fix: 修复 WebGPU 模式渲染问题 (#2450) * fix: mapbox 线图层的贴图变形 (#2474) * fix: mapbox 线图层的贴图变形 * fix: 修复热力蜂窝图层渲染空白 (#2500) * fix: 修复热力蜂窝图层渲染空白 * fix: 无地图与 MapLibre 模式移动 Marker 出错 (#2509) * fix: marker 拖动报错 * fix: 在 WebGL2 拾取事件冒泡延迟问题 (#2511) * fix: 在 WebGL2 拾取事件冒泡延迟问题 * fix: 天地图 setCenter 方法缺失 (#2513) * fix: 天地图 setCenter 方法缺失 * fix: 修复在 Map 上使用组件事件穿透到图层上的问题 (#2518) * fix: 修复在 Map 上使用组件事件穿透到图层上的问题 * fix: 解决 GeometryLayer 在不同底图上的渲染不一致情况 (#2523) * fix: 解决 GeometryLayer 在不同底图上的渲染不一致情况 * fix: 统一地形高度 * refactor: 升级新版一方地图交互事件机制，解决抖动问题 (#2521) * refactor: 升级新版地图交互事件机制 * refactor: 默认升级 MapNext 至 maplibre-gl-js@4.3.2 * fix: 顶点着色器与片元着色器 varying 变量顺序不一致 (#2527) * fix: 修复 bindings 缓存在 WebGPU 的问题 (#2526) * fix: 修复 bindings 缓存在 WebGPU 的问题 --------- Co-authored-by: lvisei <26923747+lvisei@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？
🔗 相关 Issue
💡 问题出现原因
在 WebGPU 下，每次 model draw 创建新 Pipeline，使用了缓存 createBindings，导致新的 Pipeline 使用 getBindGroupLayout 不一致。
因 L7 API 设计原因，draw 动态传入的参数（比如 stencil），必须每次创建 Pipeline，后续设计新 API 考虑 Pipeline 缓存情况。