Skip to content

Commit

Permalink
fix: 图层接口类型缺失 (#238)
Browse files Browse the repository at this point in the history
  • Loading branch information
lvisei committed Oct 31, 2022
1 parent d7199bc commit ec237ae
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 18 deletions.
2 changes: 2 additions & 0 deletions packages/composite-layers/src/types/interface.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ export interface ILayerGroup {
* 核心图层的基类接口
*/
export interface ICoreLayer {
options: Record<string, any>;
name: string;
id: string;
type: string;
Expand Down Expand Up @@ -73,6 +74,7 @@ export interface ICoreLayer {
* 复合图层的基类接口
*/
export interface ICompositeLayer {
options: Record<string, any>;
name: string;
id: string;
type: string;
Expand Down
4 changes: 2 additions & 2 deletions packages/l7plot/__tests__/unit/core/plot/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -113,15 +113,15 @@ describe('core plot', () => {
try {
expect(dotMap.zoomControl).toBeDefined();
expect(dotMap.scaleControl).toBeDefined();
expect(dotMap.layerMenuControl).toBeDefined();
// expect(dotMap.layerMenuControl).toBeDefined();

dotMap.removeZoomControl();
dotMap.removeScaleControl();
dotMap.removeLayerMenuControl();

expect(dotMap.zoomControl).toBeUndefined();
expect(dotMap.scaleControl).toBeUndefined();
expect(dotMap.layerMenuControl).toBeUndefined();
// expect(dotMap.layerMenuControl).toBeUndefined();
resolve();
} catch (err) {
reject(err);
Expand Down
2 changes: 1 addition & 1 deletion packages/l7plot/src/component/legend.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { IControlOption } from '@antv/l7-core';
import { IControlOption } from '@antv/l7';
import { Control } from '@antv/l7-component';
import { CategoryLegendOptions, ContinueLegendOptions, CategoryLegend, ContinueLegend } from '@antv/l7plot-component';

Expand Down
30 changes: 15 additions & 15 deletions packages/l7plot/src/core/map/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Scene } from '@antv/l7-scene';
import { Mapbox, GaodeMap } from '@antv/l7-maps';
import { Scale, Layers, Zoom } from '@antv/l7-component';
import { Scale, Zoom } from '@antv/l7-component';
import EventEmitter from '@antv/event-emitter';
import { isObject, isBoolean, isUndefined, isEqual } from '@antv/util';
import { Tooltip } from '../../component/tooltip';
Expand Down Expand Up @@ -88,7 +88,7 @@ export abstract class Map<O extends MapOptions> extends EventEmitter {
/**
* layerMenu 图层列表 Control
*/
public layerMenuControl: Layers | undefined;
// public layerMenuControl: Layers | undefined;
/**
* legend 图例 Control
*/
Expand Down Expand Up @@ -530,26 +530,26 @@ export abstract class Map<O extends MapOptions> extends EventEmitter {
* 添加 layerMenu 控件
*/
public addLayerMenuControl(options: LayerMenuControlOptions) {
if (this.layerMenuControl) {
return;
}
// if (this.layerMenuControl) {
// return;
// }
const baseLayers = {};
const overlayers = {};
this.layerGroup.getLayers().forEach(({ name, layer }) => {
overlayers[name] = layer;
});
this.layerMenuControl = new Layers(Object.assign({}, options, { baseLayers, overlayers }));
this.scene.addControl(this.layerMenuControl);
// this.layerMenuControl = new Layers(Object.assign({}, options, { baseLayers, overlayers }));
// this.scene.addControl(this.layerMenuControl);
}

/**
* 更新 layerMenu 控件
*/
public updateLayerMenuControl(options: LayerMenuControlOptions) {
if (!this.layerMenuControl) {
this.addLayerMenuControl(options);
return;
}
// if (!this.layerMenuControl) {
// this.addLayerMenuControl(options);
// return;
// }
this.removeLayerMenuControl();
this.addLayerMenuControl(options);
}
Expand All @@ -558,10 +558,10 @@ export abstract class Map<O extends MapOptions> extends EventEmitter {
* 移除 layerMenu 控件
*/
public removeLayerMenuControl() {
if (this.layerMenuControl) {
this.layerMenuControl.remove();
this.layerMenuControl = undefined;
}
// if (this.layerMenuControl) {
// this.layerMenuControl.remove();
// this.layerMenuControl = undefined;
// }
}

/**
Expand Down
1 change: 1 addition & 0 deletions packages/l7plot/src/types/control.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export type ScaleControlOptions = {
/**
* LayerMenuControl
*/
// TODO: 类型更新
export type LayerMenuControlOptions = {
position?: PositionName;
collapsed?: boolean;
Expand Down

0 comments on commit ec237ae

Please sign in to comment.