fix(pivot-table): optmize render func logic

antvis · Sep 2, 2021 · 5a86a3f · 5a86a3f
1 parent a2d44ea
commit 5a86a3f
Showing 1 changed file with 8 additions and 12 deletions.
diff --git a/packages/s2-core/src/sheet-type/index.ts b/packages/s2-core/src/sheet-type/index.ts
@@ -259,14 +259,11 @@ export class SpreadSheet extends EE {
     this.options = merge(this.options, options);
   }
 
-  public render(reloadData = true): Promise<void> {
-    return new Promise((resolve) => {
-      if (reloadData) {
-        this.dataSet.setDataCfg(this.dataCfg);
-      }
-      this.buildFacet();
-      resolve();
-    });
+  public render(reloadData = true) {
+    if (reloadData) {
+      this.dataSet.setDataCfg(this.dataCfg);
+    }
+    this.buildFacet();
   }
 
   public destroy() {
@@ -585,10 +582,9 @@ export class SpreadSheet extends EE {
       collapsedRows: options.style.collapsedRows,
     });
     this.setOptions(options);
-    this.render(false).then(() => {
-      this.emit(S2Event.LAYOUT_AFTER_COLLAPSE_ROWS, {
-        collapsedRows: options.style.collapsedRows,
-      });
+    this.render(false);
+    this.emit(S2Event.LAYOUT_AFTER_COLLAPSE_ROWS, {
+      collapsedRows: options.style.collapsedRows,
     });
   }