Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

升级 S2 到 2.0 的问题 #2585

Closed
5 tasks
XiChaoMing opened this issue Mar 7, 2024 · 9 comments
Closed
5 tasks

升级 S2 到 2.0 的问题 #2585

XiChaoMing opened this issue Mar 7, 2024 · 9 comments
Labels
next 2.0-next 版本的问题 ❔question 疑问/使用问题 released on @next

Comments

@XiChaoMing
Copy link

🏷 Version

Package Version
@antv/s2 1.30.0
@antv/s2-react 1.27.0
antd 4.9.4

Sheet Type

  • PivotSheet
  • TableSheet
  • GridAnalysisSheet
  • StrategySheet
  • EditableSheet

🖋 Description

  • 本地项目使用的 antd 版本为 4.9.4
  • 需要升级 s2 到 2.0 版本
  • 看到 s2-react 的 2.0 版本依赖的 antd 版本为 5.12.2
  • 升级 s2 前需要先升级 antd 版本么?(PS: 目前项目在升级完 s2 后报编译错误,不知道缺少了哪个 loader进行编译,见下图,antd 暂未升级)

image

🔗 Reproduce Link

😊 Expected Behavior

😅 Current Behavior

@XiChaoMing XiChaoMing added the ❔question 疑问/使用问题 label Mar 7, 2024
Copy link
Contributor

github-actions bot commented Mar 7, 2024

你要找的是不是 (You may look for issues):

  1. 92% 升级 S2 到 2.0 版本的问题 #2584

@lijinke666
Copy link
Member

lijinke666 commented Mar 7, 2024

升级 s2 前需要先升级 antd 版本么?

需要, s2-react 对应的 antd peerDependencies 是 >= 5.0.0

PS: 目前项目在升级完 s2 后报编译错误,不知道缺少了哪个 loader进行编译,见下图,antd 暂未升级)

这个是源码里 ?? 空值合并运算符未编译的问题, 和 @antv/s2-react 和是否升级 antd 没关系, 可以检查下你配置的打包工具对应的 loader 是不是把 node_modules 里面的 exclude 掉了, 请参考这个 #2550 (comment), 我们后面打包的时候优化下, 把 ?? 也编译一下算了.

@lijinke666
Copy link
Member

#2550

@XiChaoMing
Copy link
Author

好的,谢谢~

@lijinke666
Copy link
Member

resolved #2587

@lijinke666
Copy link
Member

🎉 This issue has been resolved in version @antv/s2-v2.0.0-next.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This issue has been resolved in version @antv/s2-react-v2.0.0-next.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member

🎉 This issue has been resolved in version @antv/s2-vue-v2.0.0-next.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@XiChaoMing
Copy link
Author

项目本身的 antd 版本为 4,升级 antd 影响很大,咱们不考虑取消 antd 的强绑定么?

@lijinke666 lijinke666 added the next 2.0-next 版本的问题 label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 ❔question 疑问/使用问题 released on @next
Projects
None yet
Development

No branches or pull requests

2 participants