Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Issue templates #43

Merged
merged 2 commits into from Dec 23, 2021
Merged

upgrade Issue templates #43

merged 2 commits into from Dec 23, 2021

Conversation

cliffordfajardo
Copy link
Contributor

@cliffordfajardo cliffordfajardo commented Dec 17, 2021

What is the change?

  1. Update the bug_report.yml github file to enable Github's new issue template form
  2. Add config.yml inside file the .github/ISSUE_TEMPLATE/ folder
  3. Update feature_request.md to feature_request.yml

Motivation for this code change?

  • encourage's bug reporter's to put more care into their bug report before submission
  • this may help XFlow maintainer's receive more detailed & higher quality bug report's
  • prevents bug reporter from submitting a bug IF they do not fill in the required fields specified in the bug_report.yml file
  • adds helpful tips for user's during the process of creating a bug/issue report
  • encourages community to ask question's inside of X6's Discussion tab

Related

Example / Demo:

Issue template example :
CleanShot 2021-12-17 at 11 38 47

References

@xflow-bot xflow-bot bot added the PR: unreviewed PR does not have any reviews. label Dec 17, 2021
@xflow-bot
Copy link
Contributor

xflow-bot bot commented Dec 17, 2021

👋 @cliffordfajardo

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript, JavaScript, CSS and React coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@xflow-bot xflow-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 17, 2021
@cliffordfajardo
Copy link
Contributor Author

cliffordfajardo commented Dec 18, 2021

@lyn-boyu @NewByVector

@lyn-boyu lyn-boyu merged commit a3e38c5 into antvis:master Dec 23, 2021
@xflow-bot xflow-bot bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels Dec 23, 2021
@xflow-bot
Copy link
Contributor

xflow-bot bot commented Dec 23, 2021

👋 @cliffordfajardo

Congrats on merging your first pull request! 🎉🎉🎉

@lyn-boyu lyn-boyu linked an issue Dec 23, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged PR has merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Github Discussions for XFlow
2 participants