fix: when chart is clear, chart.getSnapRecords() should not be affected.

antvis · May 17, 2018 · 1dbdd79 · 1dbdd79
1 parent e578106
commit 1dbdd79
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/chart/chart.js b/src/chart/chart.js
@@ -593,7 +593,10 @@ class Chart extends Base {
   **/
   getSnapRecords(point) {
     const geom = this.get('geoms')[0];
-    const data = geom.getSnapRecords(point);
+    let data = [];
+    if (geom) { // need to judge
+      data = geom.getSnapRecords(point);
+    }
     return data;
   }
 

diff --git a/test/unit/chart/chart-spec.js b/test/unit/chart/chart-spec.js
@@ -297,6 +297,18 @@ describe('chart test', () => {
       const backPlot = chart.get('backPlot');
       expect(frontPlot.get('children').length).to.equal(1);
       expect(backPlot.get('children').length).to.equal(1);
+
+      // chart be cleared, check the robustness of getSnapRecords method
+      let data;
+      const throwFn = () => {
+        try {
+          data = chart.getSnapRecords({ x: 250, y: 150 });
+        } catch (err) {
+          throw new Error(err);
+        }
+      };
+      expect(throwFn).to.not.throw();
+      expect(data).to.be.an('array').that.is.empty;
     });
 
     it('change coord', function() {