Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 完善JSX.Element type的类型 #1259

Merged
merged 1 commit into from
Nov 12, 2021
Merged

fix: 完善JSX.Element type的类型 #1259

merged 1 commit into from
Nov 12, 2021

Conversation

zengyue
Copy link
Member

@zengyue zengyue commented Nov 11, 2021

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

edokeh
edokeh reviewed Nov 11, 2021
View reviewed changes
packages/f2/src/jsx/interface.d.ts Outdated
@@ -7,12 +7,17 @@ interface Props {
[propName: string]: any;
}

export type F2ComponentLike =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是什么鬼。。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

就是jsx里标签的类型

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type 字段对应的类型

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这名字看着怪怪的。。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改成ElementType了

@zengyue zengyue force-pushed the fix-jsx-element-type branch 4 times, most recently from de06e15 to b4c7814 Compare November 12, 2021 06:05
@zengyue zengyue merged commit 0b1ce24 into v4.0.x Nov 12, 2021
@zengyue zengyue deleted the fix-jsx-element-type branch November 12, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edokeh edokeh edokeh left review comments

@ACERY1 ACERY1 ACERY1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zengyue @edokeh @ACERY1