fix(line): 数据为空时,图表更新渲染失败 #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshmyw
force-pushed
the
fix/chart-update-empty-data
branch
from
0c2ff79
to
3d69315
Compare
zengyue
reviewed
Aug 22, 2022
| @@ -394,7 +394,9 @@ class Geometry< | |||
| ...defaultAttrValues, | |||
| }; | |||
| const firstChild = children[0]; | |||
|
|
|||
| if(!firstChild) { | |||
There was a problem hiding this comment.
这个判断感觉用 children.length === 0 会比较合理吧？
mshmyw
force-pushed
the
fix/chart-update-empty-data
branch
from
46d7ba8
to
96fdd48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change