Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: geom repaint #915

Merged
merged 2 commits into from
Jun 11, 2020
Merged

fix: geom repaint #915

merged 2 commits into from
Jun 11, 2020

Conversation

cycgit
Copy link
Contributor

@cycgit cycgit commented Jun 11, 2020

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change
 const data = [
      {
        type: 'type1',
        value: 1,
      },
      {
        type: 'type2',
        value: 5,
      },
      {
        type: 'type3',
        value: 10,
      },
      {
        type: 'type4',
        value: 20,
      },
    ]

    const chart = new F2.Chart({
      id: 'el',
    });

    chart.source(data);

    chart.line().position('type*value');

    chart.render();

    // Uncaught TypeError: Cannot read property 'scales' of undefined
    chart.line().position('type*value');

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants