Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crosshairs): crosshairs 删除在坐标轴外不能显示的配置 #4008

Merged
merged 2 commits into from
Jul 4, 2022

Conversation

ai-qing-hai
Copy link
Collaborator

@ai-qing-hai ai-qing-hai commented Jun 27, 2022

image

fixed #3004

@github-actions
Copy link

github-actions bot commented Jun 27, 2022

🎊 PR Preview 56ff97b has been successfully built and deployed to https://antvis-G2-preview-pr-4008.surge.sh?type=diff&date=2022-07-04

🕐 Build time: 83.273s

🤖 By Surge Ui Insight

@github-actions github-actions bot added bugfix and removed bugfix labels Jun 27, 2022
@ai-qing-hai ai-qing-hai changed the title fix(crosshairs): crosshairs 添加 inCoordinate 属性,控制是否 坐标轴外点也可以渲染 fix(crosshairs): crosshairs 删除在坐标轴外不能显示的配置 Jun 27, 2022
@github-actions github-actions bot added bugfix and removed bugfix labels Jun 27, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2581674566

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 91.284%

Totals Coverage Status
Change from base Build 2566322000: 0.05%
Covered Lines: 11818
Relevant Lines: 12454

💛 - Coveralls

@visiky
Copy link
Member

visiky commented Jul 4, 2022

inCoordinate 这个配置还需要吗?我感觉不需要

@ai-qing-hai
Copy link
Collaborator Author

@visiky 这个配置已经删了。 是直接去除在最标轴内才能显示的代码。 没有加配置了

@visiky visiky merged commit 56ff97b into master Jul 4, 2022
@visiky visiky deleted the fix-crosshairs-coordinate branch July 4, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tooltip辅助线 不跟随tooltip
3 participants