New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2/column): support grouped and stacked bar #1357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
This pull request fixes 1 alert when merging 0310e1c into 3d760b6 - view on LGTM.com fixed alerts:
|
支持维持 v1 设计,x y 分别表示物理意义上的横向和纵向,有以下 3 个原因:
|
ok,你说的是对的。我昨天发起了一个投票,看看外部开发者对这个是什么意见。然后再做决定可以嘛? |
另外,对于 bar 和 column 代码重复比较多的问题,是否可以:
function getTooltip(type: string) {
return (params) => {
// do your things
}
} |
在外部开发群投票,参入人不多,总共 17 人。 结果相差不大,那就还是保留现状。 |
如果维持原设计的话,代码重复度就还好,还是有很多地方需要做特殊配置的,先维持现状吧 |
紧跟刀哥的步伐
TODO: