Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/duax: 关闭多个图例 #1888

Merged
merged 2 commits into from
Nov 10, 2020
Merged

feat/duax: 关闭多个图例 #1888

merged 2 commits into from
Nov 10, 2020

Conversation

liuzhenying
Copy link
Member

@liuzhenying liuzhenying commented Nov 9, 2020

  • 支持关闭多个图例
  • unit test

@liuzhenying liuzhenying changed the title feat: 支持关闭多个图例 [WIP] feat: 支持关闭多个图例 Nov 9, 2020
@pr-triage pr-triage bot removed the PR: unreviewed label Nov 9, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2020

🎊 PR Preview e213ddc has been successfully built and deployed to https://antvis-G2Plot-preview-pr-1888.surge.sh

🕐 Build time: 581.449s

🤖 By surge-preview

@liuzhenying liuzhenying changed the title [WIP] feat: 支持关闭多个图例 [WIP] fix/duax: 关闭多个图例 & 空状态处理 Nov 9, 2020
@coveralls
Copy link

coveralls commented Nov 9, 2020

Pull Request Test Coverage Report for Build 355087297

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 96.051%

Totals Coverage Status
Change from base Build 353953098: 0.7%
Covered Lines: 3713
Relevant Lines: 3766

💛 - Coveralls

@liuzhenying liuzhenying changed the title [WIP] fix/duax: 关闭多个图例 & 空状态处理 feat/duax: 关闭多个图例 Nov 10, 2020
@hustcc hustcc merged commit e213ddc into master Nov 10, 2020
@hustcc hustcc deleted the fix/dual-axes branch November 10, 2020 03:17
jinhuiWong pushed a commit to jinhuiWong/G2Plot that referenced this pull request Nov 15, 2020
* feat: 支持关闭多个图例

* fix: remove console & unit destory

Co-authored-by: aiyin.lzy <nadia.lzy@antfin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants