Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(violin): 修复小提琴图数据为空时，渲染直接抛出 error #2626

Merged
merged 1 commit into from
Jun 11, 2021
Merged

fix(violin): 修复小提琴图数据为空时，渲染直接抛出 error #2626

merged 1 commit into from
Jun 11, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Jun 10, 2021 •
edited
Loading

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

Screenshot

Before After
❌ ✅

@visiky visiky requested review from hustcc and lxfu1 June 10, 2021 14:21
@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2021 •
edited
Loading

🎊 PR Preview 3326752 has been successfully built and deployed to https://antvis-G2Plot-preview-pr-2626.surge.sh?type=diff&date=2021-06-10

🕐 Build time: 83.811s

🤖 By surge-preview

@coveralls
Copy link

Pull Request Test Coverage Report for Build 925437845

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 96.056%
Files with Coverage Reduction New Missed Lines %
src/plots/violin/adaptor.ts 1 95.73%
Totals Coverage Status
Change from base Build 923435464: 0.0%
Covered Lines: 5981
Relevant Lines: 6075
💛 - Coveralls

@lxfu1 lxfu1 merged commit f398e67 into master Jun 11, 2021
@lxfu1 lxfu1 deleted the fix-violin-changedata branch June 11, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxfu1 lxfu1 lxfu1 approved these changes

@hustcc hustcc Awaiting requested review from hustcc

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@visiky @coveralls @lxfu1