Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat: versions select #85

Merged
merged 3 commits into from
Dec 20, 2019
Merged

feat: versions select #85

merged 3 commits into from
Dec 20, 2019

Conversation

afc163
Copy link
Contributor

@afc163 afc163 commented Dec 20, 2019

close #84

image

接入方式,添加这个属性即可,这个功能只提供切换器,旧版本文档需要自行部署。https://github.com/antvis/gatsby-theme-antv/pull/85/files#diff-04c6e90faac2675aa89e2176d2eec7d8R96

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Dec 20, 2019

Deploy preview for gatsby-theme-antv ready!

Built with commit 25037bf

https://deploy-preview-85--gatsby-theme-antv.netlify.com

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

className={styles.versions}
dropdownMatchSelectWidth={false}
size="small"
onChange={value => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

@afc163 afc163 changed the title Multiple versions select feat: versions select Dec 20, 2019
@auto-add-label auto-add-label bot added the enhancement New feature or request label Dec 20, 2019
@afc163 afc163 merged commit f80e7bf into master Dec 20, 2019
@afc163 afc163 deleted the multiple-versions-select branch December 20, 2019 03:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request PR: merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

支持多版本切换
2 participants