New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brucetoo check if viewCellWidth0Indexes needed #56

Closed

todo bot opened this issue Apr 23, 2021 · 0 comments

Labels

todo bot commented Apr 23, 2021

S2/packages/s2-core/src/facet/index.ts

Lines 503 to 508 in 7087ec2

    
           // TODO brucetoo check if viewCellWidth0Indexes needed 
        
           const newIndexes = add.filter(([i, j]) => { 
        
             return ( 
        
               !includes(this.viewCellWidth0Indexes, i) && 
        
               !includes(this.viewCellHeight0Indexes, j) 
        
             );

This issue was generated by todo based on a `TODO` comment in `7087ec2` when #55 was merged. cc @antvis.

The text was updated successfully, but these errors were encountered:

todo bot added the todo 🗒️ label

xingwanying closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment