fix(band): computed wrong length of adjustRange

antvis · Jul 6, 2021 · 2bc6f8e · 2bc6f8e
1 parent 5cc43d0
commit 2bc6f8e
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 49 deletions.
diff --git a/__tests__/unit/scales/band.spec.ts b/__tests__/unit/scales/band.spec.ts
@@ -74,6 +74,16 @@ describe('band scale', () => {
     expect(bandScale.getStep()).toBeCloseTo(147.059, 3);
   });
 
+  test('test padding-inner and padding-outer options', () => {
+    const scale = new Band({
+      domain: ['A', 'B', 'C'],
+      paddingInner: 1,
+    });
+    expect(scale.map('C')).toBe(1);
+    // @ts-ignore
+    expect(scale.adjustedRange).toEqual([0, 0.5, 1]);
+  });
+
   test('test round option', () => {
     // 取整测试
     const bandScale = new Band({

diff --git a/__tests__/unit/utils/sequence.spec.ts b/__tests__/unit/utils/sequence.spec.ts
diff --git a/src/scales/band.ts b/src/scales/band.ts
@@ -1,6 +1,5 @@
 import { BandOptions } from '../types';
 import { Ordinal } from './ordinal';
-import { sequence } from '../utils/sequence';
 
 interface BandStateOptions {
   /** step 的数目。一般是 domain 的长度 */
@@ -78,7 +77,7 @@ function getBandState(opt: BandStateOptions) {
   }
 
   // 转化后的 range
-  const adjustedRange = sequence(rangeStart, rangeEnd, step);
+  const adjustedRange = new Array(stepAmount).fill(0).map((_, i) => rangeStart + i * step);
 
   return {
     step,

diff --git a/src/utils/sequence.ts b/src/utils/sequence.ts