Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: opt computeBandState & use internMap instead of Map #194

Merged
merged 1 commit into from
Sep 6, 2022
Merged

feat: opt computeBandState & use internMap instead of Map #194

merged 1 commit into from
Sep 6, 2022

Conversation

pepper-nice
Copy link
Contributor

Feature

  1. Optmize computeBandState: band scales only do simple calculation if no flex option.
  2. Use InternMap instead of Map to deal with the key of the object type.

Relation Issue

#193

pearmini
pearmini requested changes Sep 5, 2022
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大部分没有问题，但是需要增加单测测试在有 flex 属性的前提下，band 比例尺能正确的获得 Date 类型的值的 step 和 bandWidth。

@pepper-nice pepper-nice force-pushed the fix/band-bu branch 2 times, most recently from ae85eb2 to 445ad00 Compare September 5, 2022 08:22
pearmini
pearmini approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pearmini pearmini merged commit 8908324 into master Sep 6, 2022
@pearmini pearmini deleted the fix/band-bu branch September 6, 2022 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearmini pearmini pearmini approved these changes

@visiky visiky Awaiting requested review from visiky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pepper-nice @pearmini