Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: common handler of halo and selection widget #161

Merged
merged 1 commit into from Jun 2, 2020
Merged

refactor: common handler of halo and selection widget #161

merged 1 commit into from Jun 2, 2020

Conversation

bubkoo
Copy link
Member

@bubkoo bubkoo commented Jun 2, 2020

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@auto-add-label auto-add-label bot added the refactor A code change that neither fixes a bug nor adds a feature. label Jun 2, 2020
@pr-triage pr-triage bot added the PR: unreviewed PR does not have any reviews. label Jun 2, 2020
tests-checker[bot]
tests-checker bot suggested changes Jun 2, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@pr-triage pr-triage bot added PR: reviewed-changes-requested PR has reviewed and got Change request event. and removed PR: unreviewed PR does not have any reviews. labels Jun 2, 2020
@github-actions github-actions bot added PR(feature) :tada: New feature pkg:x6 labels Jun 2, 2020
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 2, 2020

This pull request fixes 1 alert when merging 0d81f29 into e439f5b - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@bubkoo bubkoo merged commit 3c5877f into master Jun 2, 2020
@bubkoo bubkoo deleted the feat/halo branch June 2, 2020 04:08
@pr-triage pr-triage bot added PR: merged PR has merged. and removed PR: reviewed-changes-requested PR has reviewed and got Change request event. labels Jun 2, 2020
@x6-bot
Copy link
Contributor

x6-bot bot commented Mar 7, 2021

🎉 This PR is included in the following release 🎉

Thanks for being a part of the AntV community! 💪💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker requested changes

Assignees
No one assigned
Labels
PR(feature) :tada: New feature PR: merged PR has merged. refactor A code change that neither fixes a bug nor adds a feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bubkoo