Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancements with doc writing #82

Merged
merged 76 commits into from
Mar 26, 2020
Merged

enhancements with doc writing #82

merged 76 commits into from
Mar 26, 2020

Conversation

bubkoo
Copy link
Member

@bubkoo bubkoo commented Feb 28, 2020

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Mar 3, 2020

This pull request introduces 11 alerts when merging cf6319f into 47dce36 - view on LGTM.com

new alerts:

  • 4 for Superfluous trailing arguments
  • 3 for Illegal invocation
  • 1 for Missing variable declaration
  • 1 for Unused variable, import, function or class
  • 1 for Use of returnless function
  • 1 for Unneeded defensive code

@@ -3,5 +3,5 @@
/**
* Auto generated version file, do not modify it!
*/
const version = '0.2.6'
const version = '0.2.7'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

自动生成的文件不要放在源码仓库里,git ignore 掉,发布时生成即可。

@pr-triage pr-triage bot added the PR: unreviewed PR does not have any reviews. label Mar 17, 2020
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Mar 25, 2020

This pull request introduces 2 alerts and fixes 1 when merging 8d1cf6b into 02f8f45 - view on LGTM.com

new alerts:

  • 1 for Expression has no effect
  • 1 for Incomplete URL scheme check

fixed alerts:

  • 1 for Incomplete URL scheme check

@bubkoo bubkoo merged commit 2812ed1 into master Mar 26, 2020
@bubkoo bubkoo deleted the doc branch March 26, 2020 02:20
@pr-triage pr-triage bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels Mar 26, 2020
@x6-bot
Copy link
Contributor

x6-bot bot commented Mar 7, 2021

🎉 This PR is included in the following release 🎉

Thanks for being a part of the AntV community! 💪💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged PR has merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants