Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade of view engine #90

Merged
merged 192 commits into from May 1, 2020
Merged

upgrade of view engine #90

merged 192 commits into from May 1, 2020

Conversation

bubkoo
Copy link
Member

@bubkoo bubkoo commented Mar 26, 2020

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pr-triage pr-triage bot added the PR: unreviewed PR does not have any reviews. label Mar 26, 2020
tests-checker[bot]
tests-checker bot suggested changes Mar 26, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@pr-triage pr-triage bot added PR: reviewed-changes-requested PR has reviewed and got Change request event. and removed PR: unreviewed PR does not have any reviews. labels Mar 26, 2020
@github-actions github-actions bot added PR(feature) :tada: New feature pkg:x6 labels Mar 26, 2020
@pr-triage pr-triage bot added PR: unreviewed PR does not have any reviews. and removed PR: reviewed-changes-requested PR has reviewed and got Change request event. labels Mar 31, 2020
@bubkoo
Copy link
Member Author

bubkoo commented Apr 25, 2020

/rebase

accesslint[bot]
accesslint bot suggested changes Apr 25, 2020
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

examples/x6-example-features/src/pages/v1/graph/background-card.tsx
value={this.state.color}
style={{ width: '100%' }}
onChange={this.onColorChanged}
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

examples/x6-example-features/src/pages/v1/graph/background-card.tsx
style={{ width: '100%' }}
value={this.state.repeat}
onChange={this.onRepeatChanged}
>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

examples/x6-example-features/src/pages/v1/graph/background-card.tsx
style={{ width: '100%' }}
value={this.state.position}
onChange={this.onPositionChanged}
>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

examples/x6-example-features/src/pages/v1/graph/background-card.tsx
style={{ width: '100%' }}
value={this.state.size}
onChange={this.onSizeChanged}
>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

@pr-triage pr-triage bot added PR: reviewed-changes-requested PR has reviewed and got Change request event. and removed PR: unreviewed PR does not have any reviews. labels Apr 25, 2020
@pr-triage pr-triage bot added PR: unreviewed PR does not have any reviews. and removed PR: reviewed-changes-requested PR has reviewed and got Change request event. labels Apr 25, 2020
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Apr 25, 2020

This pull request fixes 3 alerts when merging 943415a into 7a5a56b - view on LGTM.com

fixed alerts:

  • 1 for Identical operands
  • 1 for Expression has no effect
  • 1 for Incomplete URL scheme check

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Apr 26, 2020

This pull request fixes 3 alerts when merging 58a1a5c into 7a5a56b - view on LGTM.com

fixed alerts:

  • 1 for Identical operands
  • 1 for Expression has no effect
  • 1 for Incomplete URL scheme check

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Apr 28, 2020

This pull request fixes 3 alerts when merging 485f52e into 7a5a56b - view on LGTM.com

fixed alerts:

  • 1 for Identical operands
  • 1 for Expression has no effect
  • 1 for Incomplete URL scheme check

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 1, 2020

This pull request fixes 3 alerts when merging 770f694 into 7a5a56b - view on LGTM.com

fixed alerts:

  • 1 for Identical operands
  • 1 for Expression has no effect
  • 1 for Incomplete URL scheme check

@bubkoo bubkoo merged commit 0697d9c into master May 1, 2020
@bubkoo bubkoo deleted the feat/view branch May 1, 2020 15:00
@pr-triage pr-triage bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels May 1, 2020
@x6-bot
Copy link
Contributor

x6-bot bot commented Mar 7, 2021

🎉 This PR is included in the following release 🎉

Thanks for being a part of the AntV community! 💪💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@accesslint accesslint[bot] accesslint requested changes

@tests-checker tests-checker[bot] tests-checker requested changes

Assignees
No one assigned
Labels
PR(feature) :tada: New feature PR: merged PR has merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bubkoo