Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
According to the documentation, the
value
prop is supposed to make the component act like a controlled input. It doesn't appear to do anything.Before Change
In order for a truly controlled component, you had to pass
value
to bothAutoComplete
andAutoCompleteInput
. While this worked, it caused a lot of confusion with how the component worked. It also had the unintended consequence of makingAutoCompleteInput
always display the current value rather than the label of the item that was passed in.After Change
Passing
value
toAutoComplete
will now make this a controlled input as described by the documentation. If thevalue
is changed outside of component, theAutoCompleteInput
will correctly update with the label associated with the newvalue
Fixes #235