Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: named export error due to build issue #250

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Conversation

Kysluss
Copy link
Collaborator

@Kysluss Kysluss commented Apr 13, 2024

Update build process to use export default and type module. This fixes an issue where under some setups you would receive a named export error

Fixes #241

Update build process to use export default and type module
Copy link

changeset-bot bot commented Apr 13, 2024

⚠️ No Changeset found

Latest commit: 59c3563

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

what-the-diff bot commented Apr 13, 2024

PR Summary

  • Set the project to use ECMAScript modules
    In this pull request, we have updated our project settings to support ECMAScript (ES) modules, a standardized format in JavaScript for working with modules. This change will enable us to use modern JavaScript features, improving the overall code quality and maintainability.

  • Updated module exportation in the Vite configuration file
    We've replaced the traditional, CommonJS way of exporting modules (module.exports) with ES export default in the Vite configuration file. This adjustment aligns the project with the latest JavaScript practices and makes our code more consistent, clean, and easier to read and manage.

@Kysluss Kysluss added the bug Something isn't working label Apr 13, 2024
@Kysluss Kysluss self-assigned this Apr 13, 2024
@Kysluss Kysluss merged commit 18fcd8c into main Apr 13, 2024
1 check passed
@Kysluss Kysluss deleted the AddModuleSupport branch April 13, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Named export error
1 participant