Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python not present in official docker images #161

Closed
labodj opened this issue Aug 30, 2020 · 3 comments
Closed

Python not present in official docker images #161

labodj opened this issue Aug 30, 2020 · 3 comments

Comments

@labodj
Copy link
Contributor

labodj commented Aug 30, 2020

Hi,
after the last update I'm unable to update the whitelist in docker environment using the official PiHole image (https://hub.docker.com/r/pihole/pihole/) since it does not have Python included, is there any workaround?

@energetictree
Copy link

energetictree commented Aug 31, 2020

instead of running inside the docker I actually prefer to running it from the outside, you could modify the pihole location to the location of database outside the docker and modify the subprocess call to run docker exec instead.

You can edit your whitelist.py

For example:
pihole_location = r'/home/pi/.config/appdata/pihole/pihole'
subprocess.call("docker exec -it pihole pihole restartdns reload", shell=True, stdout=subprocess.DEVNULL)

This would be better if it implemented with the parameter instead

@labodj
Copy link
Contributor Author

labodj commented Aug 31, 2020

@energetictree thanks for the hint, I made a PR (#162)

@anudeepND
Copy link
Owner

@labodj Thanks for the PR. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants