Support for Pi-hole running as Docker container #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With -d or --dir you can specify the actual /etc/pihole directory, useful if Pi-hole is running under as Docker container. With -D or --docker you can specify if Pi-hole is running as Docker container. Code tested with Linux.
- Update readme to add informations about scripts optional arguments for different /etc/pihole directory or docker environment. - Fixed markdown out of specs things - Add image alt text where missing - Use markdown links where possible instead of HTML ones.
- Better code types for code blocks - Use MD images on demo GIFs instead of HTML
- Fix two MD linter warnings (https://github.com/DavidAnson/markdownlint)
- Add a missing closing bracket
- Add a function that restarts Pi-hole to reduce code verbosity - Removed a double restart in uninstall script - Added restart function where needed
|
@labodj Thank you so much for your contribution. I have tested it myself and everything works fine. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a C++ programmer, never coded in Python, I've tested my code in Linux environment with Python 3.7.3 and it's working fine.
Linted with VSCode 1.48.2 with Python extension v2020.8.105369