Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repair select field and burnout issues #11

Closed
anuj672 opened this issue Nov 19, 2023 · 7 comments
Closed

repair select field and burnout issues #11

anuj672 opened this issue Nov 19, 2023 · 7 comments
Assignees

Comments

@anuj672
Copy link
Owner

anuj672 commented Nov 19, 2023

No description provided.

@anuj672
Copy link
Owner Author

anuj672 commented Nov 19, 2023

This does not look like an error FOR SELECT

https://github.com/anuj672/calorieApp_server/blob/main/forms.py#L81

it is misleading and the README setup is missing instructions

There are 4 dbs for unknown reasons, and the one it automatically works on is test DB

So when you run the application next time
try running
python3 insert_food_data.py (this injects data into the db from the CSV file found here
https://github.com/anuj672/calorieApp_server/blob/main/food_data/calories.csv

python3 application.py

@anuj672
Copy link
Owner Author

anuj672 commented Nov 19, 2023

@bhaveshittadwar
@VaibhaviSangawar
@itsJash

what was the burnout issue?

@itsJash
Copy link
Collaborator

itsJash commented Nov 19, 2023

@anuj672

There is a validation issue when inputting letters instead of numbers in the enter calories box.

@anuj672
Copy link
Owner Author

anuj672 commented Nov 19, 2023

Thanks @itsJash I am pushing a change which checks if the input is a number, However we need to message on GUI that only number are valid

@anuj672
Copy link
Owner Author

anuj672 commented Nov 19, 2023

change pushed to developement, sorry took 4 commits! need coffee! hahaha will be careful, now the page does not error and does not accept alphabets, but needs some frontend work to display something

@bhaveshittadwar
Copy link
Collaborator

We still need to show an error when the user enters anything other than an integer.

@anuj672
Copy link
Owner Author

anuj672 commented Nov 20, 2023

Added 2 validations, which displays messages that it should be a number. I have added it twice -> can be done better. We however are not working for decimals yet! (it does not accept decimals)

closing this task and adding a enhancement task for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants