Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 3 refinements #100

Closed
wants to merge 5 commits into from
Closed

Conversation

markshostak
Copy link
Collaborator

Chapter 3 refinements

Figure supporting scoping description in ch-3
Additional Chapter-3 Updates
Chapter 3  Refinements (Sabine/MXS)
@pgoyal01
Copy link
Collaborator

pgoyal01 commented Jul 13, 2019 via email

@rabiabdel rabiabdel mentioned this pull request Jul 14, 2019
rabi-abdel pushed a commit that referenced this pull request Jul 14, 2019
incorporate @markshostak pull request #100
@xavier-grall
Copy link
Collaborator

My previously merged pull request #65 is partially overridden by that one: I guess it is a due to synchro issue between pull requests

@rabi-abdel
Copy link
Collaborator

rabi-abdel commented Jul 15, 2019

Hi @xavier-grall Yes I noticed that. That was due to the fact that there were two Pull requests for Chapter 3 which both got approved simultaneously. Post Paris we will prevent two pull requests for the same chapter to be created simultaneously. For now, I will go through #65 and bring in your changes. Hope that is ok

@xavier-grall
Copy link
Collaborator

alternatively, I can also do a new pull request (if you want)

@rabi-abdel
Copy link
Collaborator

@xavier-grall no worries, let me do it easier and share with you to confirm.

Copy link
Collaborator

@bfcohen bfcohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see here that the BIOS and other firmware configurations are part of the physical layer. We need to make sure this propagates through the document correctly.

Copy link
Collaborator

@bfcohen bfcohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The storage section while not explicit about it, really seems to make the assumption that we are talking about block storage. As we do know there are several other types of storage that might be utilized by the tenants and the NFVI itself. I would recommend adding references to more general storage types. Here is a n OpenStack specific overview of the different storage types: https://docs.openstack.org/project-deploy-guide/openstack-ansible/newton/overview-storage-arch.html

Block Storage (cinder)
Object Storage (swift)
Image storage (glance)
Ephemeral storage (nova)

Copy link
Collaborator

@bfcohen bfcohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the diagram notes make it clear what is in which domain.

@rabiabdel
Copy link
Collaborator

Closing this Pull Request as it has been incorporated within #101 which will be discussed tomorrow.

@rabiabdel rabiabdel closed this Jul 15, 2019
@rabi-abdel rabi-abdel added the Archive Archive Item label Feb 26, 2020
collivier pushed a commit to anuket-project/RM that referenced this pull request Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Archive Archive Item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants