[RA1]RC1] Skip manage_snapshot in CNTT #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As detected by Orange's RC Field trial, Ceph doesn't support this feature before Rocky [1]. "AttributeError: 'RBDDriver' object has no attribute 'unmanage_snapshot'" manage_snapshot testing is fully passing in Functest SUT because CNTT is verified vs OpenStack Rocky and newer. Ceph is selected by RI as backend and is widely reused by the ecosystem. It's similar to [2]. manage_snapshot will be mandatory back once CNTT selects Rocky or newer. [1] https://bugs.launchpad.net/cinder/+bug/1645288 [2] https://gerrit.opnfv.org/gerrit/c/functest/+/69888 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
collivier
requested review from
fuqiao123,
pgoyal01 and
rabi-abdel
as code owners
iangardner22
approved these changes
May 28, 2020
karinesevilla
approved these changes
May 28, 2020
|
@collivier Since we are going to upgrade to Rocky or newer, I suggest we leave this in place and only commit PR #1629 (Baldy). Avoids unnecessary work. Or we open an issue now to reinstate so that we do not forget. My preference would be to not make the change. |
|
@rabi-abdel @rabiabdel Would you mind reviewing and merging this PR? The related change was applied in Functest (Field trial is coming) |
rabi-abdel
approved these changes
Jun 1, 2020
rabi-abdel
added a commit
that referenced
this pull request
Jun 1, 2020
This reverts commit 038b40a.
|
@collivier @rabi-abdel PR #1629 is for Baldy release and makes sense to make the change. PR #1628 is for the current viz., Baraque release and I think it would be a waste of effort to make the change now and undo later.. |
rabi-abdel
added a commit
that referenced
this pull request
Jun 1, 2020
This reverts commit 038b40a.
rabiabdel
pushed a commit
that referenced
this pull request
Jun 1, 2020
rabiabdel
added a commit
that referenced
this pull request
Jun 1, 2020
gkunz
pushed a commit
to gkunz/CNTT
that referenced
this pull request
Jun 4, 2020
As detected by Orange's RC Field trial, Ceph doesn't support this feature before Rocky [1]. "AttributeError: 'RBDDriver' object has no attribute 'unmanage_snapshot'" manage_snapshot testing is fully passing in Functest SUT because CNTT is verified vs OpenStack Rocky and newer. Ceph is selected by RI as backend and is widely reused by the ecosystem. It's similar to [2]. manage_snapshot will be mandatory back once CNTT selects Rocky or newer. [1] https://bugs.launchpad.net/cinder/+bug/1645288 [2] https://gerrit.opnfv.org/gerrit/c/functest/+/69888 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com> Co-authored-by: Cédric Ollivier <cedric.ollivier@orange.com>
gkunz
pushed a commit
to gkunz/CNTT
that referenced
this pull request
Jun 4, 2020
…roject#1647) This reverts commit 038b40a.
|
@pgoyal01 @rabi-abdel The revert is inappropriate here (and even more when the author is not aware) and frankly disconnected from the classical process. Until we switched to Train and the doc is simply false. The revert should go through the same process and not applied by admin without concensus. |
collivier
added a commit
to collivier/CNTT
that referenced
this pull request
Jul 13, 2020
It was disabled due to a former partial support [1][2][3]. [1] anuket-project#1628 [2] https://bugs.launchpad.net/cinder/+bug/1645288 [3] https://gerrit.opnfv.org/gerrit/c/functest/+/69888
rabi-abdel
pushed a commit
that referenced
this pull request
Jul 16, 2020
* Update RA1 Chapter 5 to Train It updates microversions and links according to Train. It should be noted that the last hot version is 2018-08-31 (rocky). Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com> * Add manage_snapshot in CNTT It was disabled due to a former partial support [1][2][3]. [1] #1628 [2] https://bugs.launchpad.net/cinder/+bug/1645288 [3] https://gerrit.opnfv.org/gerrit/c/functest/+/69888 * Update Barbican link It selects latest rather than train to conform to all other links in Chapter5. Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com> Co-authored-by: Cédric Ollivier <cedric.ollivier@orange.com>
collivier
added a commit
to anuket-project/RC1
that referenced
this pull request
Dec 10, 2023
* Update RA1 Chapter 5 to Train It updates microversions and links according to Train. It should be noted that the last hot version is 2018-08-31 (rocky). Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com> * Add manage_snapshot in CNTT It was disabled due to a former partial support [1][2][3]. [1] anuket-project/anuket-specifications#1628 [2] https://bugs.launchpad.net/cinder/+bug/1645288 [3] https://gerrit.opnfv.org/gerrit/c/functest/+/69888 * Update Barbican link It selects latest rather than train to conform to all other links in Chapter5. Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com> Co-authored-by: Cédric Ollivier <cedric.ollivier@orange.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As detected by Orange's RC Field trial, Ceph doesn't support this
feature before Rocky [1].
"AttributeError: 'RBDDriver' object has no attribute 'unmanage_snapshot'"
manage_snapshot testing is fully passing in Functest SUT because CNTT
is verified vs OpenStack Rocky and newer.
Ceph is selected by RI as backend and is widely reused by the ecosystem.
It's similar to [2].
manage_snapshot will be mandatory back once CNTT selects Rocky or newer.
[1] https://bugs.launchpad.net/cinder/+bug/1645288
[2] https://gerrit.opnfv.org/gerrit/c/functest/+/69888
Signed-off-by: Cédric Ollivier cedric.ollivier@orange.com