Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Glossary] Terminology definition for testing per issue #1495 #1649

Closed
wants to merge 8 commits into from

Conversation

trevgc
Copy link
Collaborator

@trevgc trevgc commented Jun 1, 2020

Added section 1.7 for test related terminology and updated with existing text in general terminology section this is test related and with definition text from related issue.

@trevgc trevgc requested a review from rabiabdel as a code owner June 1, 2020 19:37
doc/tech/glossary.md Outdated Show resolved Hide resolved
doc/tech/glossary.md Outdated Show resolved Hide resolved
Updates to say results may be useful for comparison

- **Performance Measurement:** The procedure or set of operations having the object of determining a Measured Value or Measurement Result. In this context, Performance Measurements reflect data generated and collected within the cloud infrastructure, that reflects a performance aspect of the cloud infrastructure. For example, a count of frames or packets traversing an interface, memory usage information, other resource usage and availability, etc. These data may be instantaneous or accumulated, and made available (i.e. exposed) based on permissions and contexts (e.g., workload vs. infra).

- **Performance Testing**: The main objective of CNTT performance testing is to understand if a potential BOM is functioning correctly to get expected performance. It requires a set of performance testing tools (open source) that help with the dimensioning of a solution by an operator. Testing results may be useful to compare infrastructure capabilites between the System Under Test (SUT) and a CNTT reference implementation of RA-2. Performance testing for the purpose of comparing between different commercial implementations is not a goal of CNTT. Performance testing relies on well established benchmark specifications.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section should become an introduction for the Test Related Terminology Section, so I suggest to delete the text here and move under the section title.

Suggested change
- **Performance Testing**: The main objective of CNTT performance testing is to understand if a potential BOM is functioning correctly to get expected performance. It requires a set of performance testing tools (open source) that help with the dimensioning of a solution by an operator. Testing results may be useful to compare infrastructure capabilites between the System Under Test (SUT) and a CNTT reference implementation of RA-2. Performance testing for the purpose of comparing between different commercial implementations is not a goal of CNTT. Performance testing relies on well established benchmark specifications.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated per CVC

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acmacm can this be resolved?

doc/tech/glossary.md Show resolved Hide resolved
@rabi-abdel
Copy link
Collaborator

@trevgc would you mind please addressing comments above?

@pgoyal01 pgoyal01 added this to the M3 (Freeze Contributions) milestone Jun 9, 2020
@pgoyal01
Copy link
Collaborator

pgoyal01 commented Jun 9, 2020

Issue #1495

@xmulligan xmulligan added this to Backlog in RC2 Jun 11, 2020
@rabi-abdel
Copy link
Collaborator

@xmulligan shall this PR be closed?

@xmulligan
Copy link
Collaborator

@trevgc would you like to address the comments or should we close this PR pending further discussion in CNTT?

@xmulligan
Copy link
Collaborator

fixes #1495

@xmulligan
Copy link
Collaborator

The discussion will be moved to https://wiki.lfnetworking.org/display/LN/Performance+Testing+Minutes until a formal PR will be raised

@xmulligan xmulligan removed this from Backlog in RC2 Aug 13, 2020
@xmulligan xmulligan added this to In progress in Technical Steering via automation Aug 13, 2020
@xmulligan xmulligan requested review from scottsteinbrueck and removed request for rabiabdel August 13, 2020 16:12
@xmulligan xmulligan changed the title [RC2 Ch01] Terminology definition for testing per issue #1495 [TSC Glossary] Terminology definition for testing per issue #1495 Aug 13, 2020
1) Fixed TOC titles to march headings and updated numbering 2) Updated test terminology per CVC agreed definitions ref https://wiki.lfnetworking.org/display/LN/Performance+Testing+Minutes
@trevgc trevgc self-assigned this Aug 13, 2020
@trevgc
Copy link
Collaborator Author

trevgc commented Aug 13, 2020

Related

  1. Issue ... [RC2 Ch02] Define terminology and scope of RC2 (Functional vs. Performance) [TSC Glossary] Define test related terminology applicable across workstreams #1495
  2. PR already merged ... [RC2 Ch01] Proposed text per issue [TSC Glossary] Define test related terminology applicable across workstreams #1495 re. terminology, scope (considering performance) [RC2 Ch01] Proposed text per issue #1495 re. terminology, scope (considering performance) #1642

@scottsteinbrueck scottsteinbrueck added the Conflict To be resolved label Sep 11, 2020
Copy link
Collaborator

@scottsteinbrueck scottsteinbrueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trevgc please resolve or remove Milestone=M3. If conflicts are resolved, also remove label=Conflict. thank you.

@scottsteinbrueck scottsteinbrueck removed this from the M3 (Freeze Contributions) milestone Sep 15, 2020
@xmulligan
Copy link
Collaborator

@trevgc do you want to resolve the conflicts here or should we close it?

@collivier
Copy link
Collaborator

@xmulligan +1 to close it. We could reopen it later if needed.

@collivier collivier closed this Jan 19, 2021
Technical Steering automation moved this from In progress to Done Jan 19, 2021
@trevgc
Copy link
Collaborator Author

trevgc commented Jan 19, 2021

@trevgc do you want to resolve the conflicts here or should we close it?

@xmulligan I just saw this and looked back at the history. The pull request was approved by 3 people, I am not sure what the conflict was that needed to be resolved? Lets not lose this as the glossary needs some improvements.

@trevgc trevgc reopened this Jan 19, 2021
Technical Steering automation moved this from Done to In progress Jan 19, 2021
@trevgc trevgc removed the Conflict To be resolved label Jan 19, 2021
@pgoyal01 pgoyal01 requested review from a team January 19, 2021 23:53
Copy link
Collaborator

@pgoyal01 pgoyal01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject to conflict resolution

@pgoyal01
Copy link
Collaborator

@trevgc It states that there are conflicts and that will prevent merge

@xmulligan
Copy link
Collaborator

@trevgc if you click on the resolve conflicts button, it will show what needs to be resolved

@trevgc trevgc changed the title [TSC Glossary] Terminology definition for testing per issue #1495 [Glossary] Terminology definition for testing per issue #1495 Jan 20, 2021
trevgc added a commit that referenced this pull request Jan 20, 2021
This pull request is to replace [Glossary] Terminology definition for testing per issue #1495 #1649. Pull request #1649 has been closed as the edited file was moved and therefore could not resolve merge conflicts.
@trevgc
Copy link
Collaborator Author

trevgc commented Jan 20, 2021

Closed this pull request as it cannot be merged due to files moving around. Have replaced it with #2201

@trevgc trevgc closed this Jan 20, 2021
Technical Steering automation moved this from In progress to Done Jan 20, 2021
scottsteinbrueck pushed a commit that referenced this pull request Jan 20, 2021
This pull request is to replace [Glossary] Terminology definition for testing per issue #1495 #1649. Pull request #1649 has been closed as the edited file was moved and therefore could not resolve merge conflicts.
collivier pushed a commit that referenced this pull request Jan 21, 2021
This pull request is to replace [Glossary] Terminology definition for testing per issue #1495 #1649. Pull request #1649 has been closed as the edited file was moved and therefore could not resolve merge conflicts.

(cherry picked from commit b13a621)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[TSC Glossary] Define test related terminology applicable across workstreams
9 participants