New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RA2] Networking solution changes #2121
Conversation
Moved comparison table from ch04 to ch03
Move comparison table to ch03, check traceability of all specs, split into one spec per row.
@tomkivlin Why have a comparison table? It is limited only to 2 out of many available solutions. |
I think it's worth showing the different approaches that can be taken. Happy to add words to that effect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
Changed "must" to "should" when referring to overlay/vswitch accelerated networking - realistically one would use either this or sr-iov (underlay), but not both
@tomkivlin Does the chapter need the types of networking -- host, overlay, underlay , ...? Depending upon the type of networking chosen would determine the CNIs. |
link correction
Perhaps - I'm keen to avoid repeating Kubernetes documentation for the sake of it, so if we can link it back to the requirements then yes. |
Added ra2.ntw.009
Added `ra2.ntw.010`
@fkautz I don't know enough about NSM to know whether the specs as presented in chapter04.md prevent its use? e.g. one that concerns me is |
…CNTT into tomkivlin-ra2-networking
Until it has been reviewed/removed (#2187).
remove sfc support (not relevant) and change response for traffic symmetry to "Depends on CNI plugin used" in all cases.
@pgoyal01 @fkautz @cntt-n/ref-a2 we need just one more approval on this monster please. Many thanks for inputs so far! @tomkivlin I will approve but please see a comment w.r.t. "ra2.k8s.011 Anuket Profile Labels" below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but there is one suggestion about a reference
As per multiple discussions on the topic, I propose a change whereby the architectural components / building blocks are described in chapter 3, and this is where I think the comparison table best sits. Then the specifications in chapter 4 are cleaner and more discrete.
Resolves #2119