Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RA2] Networking solution changes #2121

Merged
merged 44 commits into from Jan 13, 2021
Merged

[RA2] Networking solution changes #2121

merged 44 commits into from Jan 13, 2021

Conversation

tomkivlin
Copy link
Collaborator

@tomkivlin tomkivlin commented Dec 8, 2020

As per multiple discussions on the topic, I propose a change whereby the architectural components / building blocks are described in chapter 3, and this is where I think the comparison table best sits. Then the specifications in chapter 4 are cleaner and more discrete.

Resolves #2119

Moved comparison table from ch04 to ch03
Move comparison table to ch03, check traceability of all specs, split into one spec per row.
@tomkivlin tomkivlin self-assigned this Dec 8, 2020
@tomkivlin tomkivlin added this to In Progress in old-RA2 via automation Dec 8, 2020
@pgoyal01
Copy link
Collaborator

pgoyal01 commented Dec 8, 2020

@tomkivlin Why have a comparison table? It is limited only to 2 out of many available solutions.

@tomkivlin
Copy link
Collaborator Author

@tomkivlin Why have a comparison table? It is limited only to 2 out of many available solutions.

I think it's worth showing the different approaches that can be taken. Happy to add words to that effect.

Copy link
Collaborator

@rgstori rgstori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Changed "must" to "should" when referring to overlay/vswitch accelerated networking - realistically one would use either this or sr-iov (underlay), but not both
doc/ref_arch/kubernetes/chapters/chapter03.md Outdated Show resolved Hide resolved
doc/ref_arch/kubernetes/chapters/chapter03.md Outdated Show resolved Hide resolved
doc/ref_arch/kubernetes/chapters/chapter03.md Outdated Show resolved Hide resolved
doc/ref_arch/kubernetes/chapters/chapter03.md Show resolved Hide resolved
doc/ref_arch/kubernetes/chapters/chapter03.md Show resolved Hide resolved
doc/ref_arch/kubernetes/chapters/chapter03.md Show resolved Hide resolved
@pgoyal01
Copy link
Collaborator

@tomkivlin Does the chapter need the types of networking -- host, overlay, underlay , ...? Depending upon the type of networking chosen would determine the CNIs.

link correction
@tomkivlin
Copy link
Collaborator Author

@tomkivlin Does the chapter need the types of networking -- host, overlay, underlay , ...? Depending upon the type of networking chosen would determine the CNIs.

Perhaps - I'm keen to avoid repeating Kubernetes documentation for the sake of it, so if we can link it back to the requirements then yes.

Added ra2.ntw.009
Added `ra2.ntw.010`
@tomkivlin
Copy link
Collaborator Author

tomkivlin commented Dec 14, 2020

@fkautz I don't know enough about NSM to know whether the specs as presented in chapter04.md prevent its use? e.g. one that concerns me is ra2.ntw.003 as I'm not sure whether NSM uses the CNI to integrate with the k8s control plane - my understanding is that it uses Device Plugin API and the kube-apiserver - is that right?

@tomkivlin tomkivlin requested a review from a team January 12, 2021 12:19
doc/ref_arch/kubernetes/chapters/chapter03.md Outdated Show resolved Hide resolved
doc/ref_arch/kubernetes/chapters/chapter04.md Outdated Show resolved Hide resolved
doc/ref_arch/kubernetes/chapters/chapter04.md Outdated Show resolved Hide resolved
Until it has been reviewed/removed (#2187).
doc/ref_arch/kubernetes/chapters/chapter03.md Outdated Show resolved Hide resolved
remove sfc support (not relevant) and change response for traffic symmetry to "Depends on CNI plugin used" in all cases.
@tomkivlin
Copy link
Collaborator Author

tomkivlin commented Jan 13, 2021

@pgoyal01 @fkautz @cntt-n/ref-a2 we need just one more approval on this monster please. Many thanks for inputs so far!

@tomkivlin I will approve but please see a comment w.r.t. "ra2.k8s.011 Anuket Profile Labels" below.

Copy link
Collaborator

@pgoyal01 pgoyal01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but there is one suggestion about a reference

@tomkivlin tomkivlin merged commit 922f967 into master Jan 13, 2021
old-RA2 automation moved this from In Progress to Done Jan 13, 2021
@tomkivlin tomkivlin deleted the tomkivlin-ra2-networking branch January 13, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
old-RA2
  
Done
Development

Successfully merging this pull request may close these issues.

[RA2 Ch2] Review NAT requirement(s)
5 participants