[RM Ch3] Update SFC Section 3.5.1 #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Service function chaining section in 3.5.1 : 3.5.1.1 Introduction
kumarsumangit
requested review from
scottsteinbrueck and
walterkozlowski
as code owners
CsatariGergely
previously requested changes
Mar 16, 2021
walterkozlowski
requested changes
Mar 16, 2021
There was a problem hiding this comment.
This is a very good beginning. However, comments from @CsatariGergely, although editorial and terminology related, are very valid. We have to maintain the consistent terminology, use industry terms (referred to a source, if not obvious). I will be happy to approve this particular PR once @kumarsumangit addresses points identified by @CsatariGergely
walterkozlowski
approved these changes
Mar 17, 2021
pgoyal01
changed the title
pgoyal01
reviewed
Mar 17, 2021
pgoyal01
reviewed
Mar 17, 2021
pgoyal01
reviewed
Mar 17, 2021
pgoyal01
reviewed
Mar 17, 2021
pgoyal01
reviewed
Mar 17, 2021
Co-authored-by: Pankaj Goyal <52107136+pgoyal01@users.noreply.github.com>
Co-authored-by: Pankaj Goyal <52107136+pgoyal01@users.noreply.github.com>
Co-authored-by: Pankaj Goyal <52107136+pgoyal01@users.noreply.github.com>
Co-authored-by: Pankaj Goyal <52107136+pgoyal01@users.noreply.github.com>
Co-authored-by: Pankaj Goyal <52107136+pgoyal01@users.noreply.github.com>
pgoyal01
approved these changes
Mar 24, 2021
karinesevilla
approved these changes
Mar 30, 2021
|
I have gone over this and it looks good to me. |
sureshkrishnan
approved these changes
Mar 31, 2021
walterkozlowski
dismissed
CsatariGergely’s stale review
The changes have been already applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2276 Update Service function chaining section in 3.5.1 : 3.5.1.1 Introduction