Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RM CH03] Added 3.4.2 Time Sensitive Workloads #2347

Closed
wants to merge 6 commits into from
Closed

[RM CH03] Added 3.4.2 Time Sensitive Workloads #2347

wants to merge 6 commits into from

Conversation

arkadykanevsky
Copy link
Collaborator

Fixes #2328

Update chapter03.md
a0d27e9 
Started Time Sensitive Chapter
@arkadykanevsky arkadykanevsky self-assigned this Apr 7, 2021
@arkadykanevsky arkadykanevsky added Kali Release Name for 1h2021 New labels Apr 7, 2021
@arkadykanevsky arkadykanevsky added this to In Progress in RM via automation Apr 7, 2021
TFredberg
TFredberg approved these changes Apr 7, 2021
View reviewed changes
Copy link
Collaborator

@TFredberg TFredberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
A minor comment or question on line 276: Do you mean "... can be on server or network device motherboard or be part of NIC of both." Slightly hard to understand and the last "of" seems wrong since the NIC is likely not existing on the network device (=switch).

@walterkozlowski walterkozlowski requested a review from a team April 7, 2021 21:20
@arkadykanevsky
Copy link
Collaborator Author

Thanks Tomas. This is a start a patch to add Time-Sensitive Networking.
I will reword it. I was trying to say that it can be in server or networking gear (like FHGW) proper or in NIC/sNICs.
Any recommendations on better wording wlecome.

TFredberg
TFredberg reviewed Apr 7, 2021
View reviewed changes
Copy link
Collaborator

@TFredberg TFredberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could suggest to change line 276 to:
Precise Synchronization require specialized hardware that can be on a server, network or transport device.

@walterkozlowski
Copy link
Collaborator

@arkadykanevsky, as discussed at the RM meeting I have changed the structure of Chapter 3 slightly. Your contents in 3.9 will be OK but you have to move your contents from 3.4.2 to under Network 3.5; I suggest creating 3.5.2 Time Sensitive Networking with this contents. Otherwise, we will not be able to merge this PR. Apologies...

CsatariGergely
CsatariGergely requested changes Apr 8, 2021
View reviewed changes
doc/ref_model/chapters/chapter03.md Outdated Show resolved Hide resolved
doc/ref_model/chapters/chapter03.md Outdated Show resolved Hide resolved
Update chapter03.md
8e22b21 
Addressing Gergely comments
@petorre petorre linked an issue Apr 12, 2021 that may be closed by this pull request
[RM] Add Timing Accuracy and PTP #2329
Closed
@walterkozlowski walterkozlowski requested a review from a team April 14, 2021 14:23
karinesevilla
karinesevilla reviewed Apr 21, 2021
View reviewed changes
doc/ref_model/chapters/chapter03.md Outdated
<a name="3.9"></a>
### 3.9 Time Sensitive Networking

Openstack and Kuberentes clusters use NTP as the default time synchronization for the cluster. That level of synchronization is not sufficient for many network functions. Just like real-time operating system requirement instead of base OS so is precision timing for clock synchronization. Precision Time Protocol version 2 [PTP] (IEEE 1588-2019) is commonly used for Time-Sensitive Networking. This allow synchronization in microsecond range rather than millisecond range that NTP provides.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arkadykanevsky
typos:
Openstack -> OpenStack
Kuberentes -> Kubernetes

@walterkozlowski
Update chapter03.md
06cb5f0 
Fixed the typos
walterkozlowski
walterkozlowski approved these changes Apr 21, 2021
View reviewed changes
Copy link
Collaborator

@walterkozlowski walterkozlowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the typos and approved

@wmk-admin
Copy link
Contributor

@arkadykanevsky, please fix typos in your branch, and I will merge - Walter

Update chapter03.md
f53c11e 
fixed typos
@arkadykanevsky
Copy link
Collaborator Author

replaced by PR2386

@arkadykanevsky
Copy link
Collaborator Author

Closed. replaced by PR 2386

RM automation moved this from In Progress to Done May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TFredberg TFredberg TFredberg approved these changes

@CsatariGergely CsatariGergely CsatariGergely requested changes

@petorre petorre petorre approved these changes

@karinesevilla karinesevilla karinesevilla approved these changes

@walterkozlowski walterkozlowski walterkozlowski approved these changes

@scottsteinbrueck scottsteinbrueck Awaiting requested review from scottsteinbrueck

@pgoyal01 pgoyal01 Awaiting requested review from pgoyal01

Assignees

@arkadykanevsky arkadykanevsky

Labels
Kali Release Name for 1h2021 New
Projects
RM
  
Done
Milestone
Kali - M3 - Content Freeze
Development

Successfully merging this pull request may close these issues.

[RM] Add Timing Accuracy and PTP [RA2 Ch3.8] Define SyncE requirement
7 participants
@arkadykanevsky @walterkozlowski @wmk-admin @petorre @CsatariGergely @TFredberg @karinesevilla