-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RM Ch02] Make changes to 2.4 for consistency #2405
Conversation
2.4 Consistency Change Figure reference
Co-authored-by: karinesevilla <52161819+karinesevilla@users.noreply.github.com>
Co-authored-by: karinesevilla <52161819+karinesevilla@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my view, the idea is correct and correctly expressed. I think that profile extensions may be applicable to Basic as well, even for symmetry and future use. I do not see any harm. It is a bit hard to read this PR because of number of corrections. I suggest resolving all comments (if there are still any unresolved) and I am happy to merge. We can still add some minor corrections in seperate PRs. @joaoarodrigues, can you provide your view as well?
Co-authored-by: karinesevilla <52161819+karinesevilla@users.noreply.github.com>
Co-authored-by: karinesevilla <52161819+karinesevilla@users.noreply.github.com>
Co-authored-by: karinesevilla <52161819+karinesevilla@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the modifications, good for me!
@walterkozlowski There is a clear understanding why 'profiles extensions' - agreed that its applicable to 'Basic' too - is proposed (... and take 'flavor' away), though, I've some challenges why not using 'Infrastructure labels' (more 'tech' meaningful) |
Fixes #2369
Align 2.4 with updates to RM Section 4.2 (PR #2366)