Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RM Ch02] Make changes to 2.4 for consistency #2405

Merged
merged 12 commits into from
May 13, 2021
Merged

Conversation

pgoyal01
Copy link
Collaborator

@pgoyal01 pgoyal01 commented May 6, 2021

Fixes #2369
Align 2.4 with updates to RM Section 4.2 (PR #2366)

Fixes #2369 
Align 2.4 with updates to RM Section 4.2 (PR #2366)
@pgoyal01 pgoyal01 added the Kali Release Name for 1h2021 label May 6, 2021
@pgoyal01 pgoyal01 added this to the Kali - M3 - Content Freeze milestone May 6, 2021
@pgoyal01 pgoyal01 added this to In Progress in RM via automation May 6, 2021
@pgoyal01 pgoyal01 changed the title [RM Ch02] 2.4 align with new 4.2 [RM Ch02] Make changes to 2.4 for consistency May 11, 2021
2.4 Consistency

Change Figure reference
@pgoyal01 pgoyal01 mentioned this pull request May 11, 2021
@pgoyal01
Copy link
Collaborator Author

Based on discussions on 2021-05-11, have made some edits and ensured that the correct Figure is in place.

Also suspended PR #2384 until this PR (#2405) and PR #2320 are completed. PR #2384 will be used to make any edits to 4.2 not covered by PR #2320 has been merged.

Co-authored-by: karinesevilla <52161819+karinesevilla@users.noreply.github.com>
Co-authored-by: karinesevilla <52161819+karinesevilla@users.noreply.github.com>
Copy link
Collaborator

@walterkozlowski walterkozlowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my view, the idea is correct and correctly expressed. I think that profile extensions may be applicable to Basic as well, even for symmetry and future use. I do not see any harm. It is a bit hard to read this PR because of number of corrections. I suggest resolving all comments (if there are still any unresolved) and I am happy to merge. We can still add some minor corrections in seperate PRs. @joaoarodrigues, can you provide your view as well?

@walterkozlowski walterkozlowski self-requested a review May 12, 2021 13:27
pgoyal01 and others added 4 commits May 12, 2021 08:11
Co-authored-by: karinesevilla <52161819+karinesevilla@users.noreply.github.com>
Co-authored-by: karinesevilla <52161819+karinesevilla@users.noreply.github.com>
Co-authored-by: karinesevilla <52161819+karinesevilla@users.noreply.github.com>
Copy link
Collaborator

@karinesevilla karinesevilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the modifications, good for me!

@joaoarodrigues
Copy link
Collaborator

In my view, the idea is correct and correctly expressed. I think that profile extensions may be applicable to Basic as well, even for symmetry and future use. I do not see any harm. It is a bit hard to read this PR because of number of corrections. I suggest resolving all comments (if there are still any unresolved) and I am happy to merge. We can still add some minor corrections in seperate PRs. @joaoarodrigues, can you provide your view as well?

@walterkozlowski There is a clear understanding why 'profiles extensions' - agreed that its applicable to 'Basic' too - is proposed (... and take 'flavor' away), though, I've some challenges why not using 'Infrastructure labels' (more 'tech' meaningful)

@wmk-admin wmk-admin merged commit 3eb560f into master May 13, 2021
RM automation moved this from In Progress to Done May 13, 2021
@wmk-admin wmk-admin deleted the pgoyal01-patch-RM-2-4 branch May 13, 2021 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kali Release Name for 1h2021
Projects
RM
  
Done
Development

Successfully merging this pull request may close these issues.

[RM Ch02] 2.4.2 Node Flavours align with updates to RM Section 4.2
8 participants