Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 01 (Terminology fixes) #60

Merged
merged 5 commits into from
Jul 9, 2019
Merged

Chapter 01 (Terminology fixes) #60

merged 5 commits into from
Jul 9, 2019

Conversation

pgoyal01
Copy link
Collaborator

@pgoyal01 pgoyal01 commented Jul 5, 2019

Made changes to some of the terms.
Still need to be resolved:

  1. Do Instance Types include sizing (number of CPUs, RAM, etc.) information or are they just the Basic, Network-Intensive, etc. Types?
  2. Still need to fix the SW/HW Profile and Configuration terms.

Made changes to some of the terms.
Still need to be resolved:
1. Do Instance Types include sizing (number of CPUs, RAM, etc.) information or are they just the Basic, Network-Intensive, etc. Types?  
2. Still need to fix the SW/HW Profile and Configuration terms.
@demels
Copy link
Collaborator

demels commented Jul 5, 2019

I suggest to remove the abbreviation vAPP and use the definition for Virtual Application as defined in ETSI GS NFV 003:

Virtual Application (VA): more general term for a piece of software which can be loaded into a Virtual Machine
NOTE: A VNF is one type of VA.

I think @pgoyal01 you have mistakenly brought the original Principles text in here. fix it.
@rabiabdel
Copy link
Collaborator

rabiabdel commented Jul 5, 2019

@pgoyal01 i think you have mistakenly replaced the principles section in this pull request with the original text, i have modified it.

@rabiabdel rabiabdel changed the title Update Chapter 01.md Chapter 01 (Terminology fixes) Jul 5, 2019
@rabiabdel
Copy link
Collaborator

There is an issue related to this: #58

@hdamker
Copy link
Collaborator

hdamker commented Jul 5, 2019

@pgoyal01 I have some further change proposals, please integrate them into your pull request if you agree:

  • Delete the abbreviation "vApp" completely, it is vendor specific. If you search for vApp you will find almost only pages from or about VMWare (try "vAPP NFV" or "vApp OpenStack")
  • VNFs are built from VNF Components, VNFC.e.g. VMs => VNFs are built from VNF Components (VNFC), a VNFC single instance is a 1:1 mapping to e.g. a VM or Container
  • NFVi => NFVI
  • Workload: Workload refers to software running on top of NFVI resources such as VMs or Containers => Workload: another general term referring to software running on (virtualized) compute resources. Most relevant workload categories in context of NFVI are: ...
    • [Background: i see this term as the most general one for the software running on NFVI (or other virtualization/cloud infrastructure. The listed subcategories under workload are only important examples, but not exhaustive]
  • the definition of "Instance type" is not correct from my perspective. Previous one was better (see also comment from @rabiabdel)
  • Tenant (Internal) Networks (a.k.a. vApp Network): delete "(a.k.a. vApp Network)", see above.
  • Compute Node: abstract definition of a physical or virtual server: delete "or virtual server" [I have never seen the term used for a virtual server, it is always referring to the hardware node from my perspective]

@ASawwaf
Copy link
Collaborator

ASawwaf commented Jul 6, 2019

@hdamker
I totally agree on most of your modification, Just small comment on:

  • VNFs are built from VNF Components, VNFC.e.g. VMs => VNFs are built from VNF Components (VNFC), a VNFC single instance is a 1:1 mapping to e.g. a VM or Container

Sawaf : VNFs are built from one or more VNF component , and in most cases, the VNFC is a single VM or container

Sawaf : Workload: it is a software ( VNF or APP ) that running over NFVI and consume the NFVI resources

@hdamker
Copy link
Collaborator

hdamker commented Jul 6, 2019

@ASawwaf: +1 for the simplified version for VNFs, I like it.
Also for Workload ... just not "APP" in it ... instead "(VNF or virtualized application)"

@ASawwaf
Copy link
Collaborator

ASawwaf commented Jul 6, 2019

agreed

@pgoyal01
Copy link
Collaborator Author

pgoyal01 commented Jul 6, 2019

@rabiabdel, @hdamker and @ASawwaf

Thanks all. Will make some of the suggested changes.

Original Definition Instance Type: "The type of NFVI of which the VM is expected to run on. It directly maps to the combination of the underlying NFVI SW Profile and NFVI HW Profile." Issues: what does "type of NFVI" mean -- since it refers to VM is expected to run on it implies the physical hardware? what is the combination of NFVI SW Profile and NFVI HW Profile? Maybe my poor wording of the sentence: "defines the capabilities of the physical compute server that the virtual compute resource can run on." ----> capabilities of the virtual compute resource and these capabilities must match the configuration (capabilities) of the physical compute server on which, say, the VM is going to be running on. And as I stated in my comments there are issues with the Profile definitions also.

VNFC -- I like Ahmed's "in most cases."

Compute node will use the ETSI 1.4.1 (2018-10).
WIll delete vApps -- will need to be deleted from other Chapters.

I will make the changes except for Instance Type until we can get a clearer definition.

Updates some of the definitions as per suggestions.

Still need cleanup on: Instance Type, Flavour, HW/SW Profile.
@ASawwaf
Copy link
Collaborator

ASawwaf commented Jul 7, 2019

@pgoyal01 , my suggestion to use Openstack definition ( with small modification ) which is " A running VM, or a VM in a known state such as suspended, that can be used like a hardware server "

my defination: It is running VM , or VM in a Known state such as (run, stop , suspend ) that can be used by any VNF or Virtual application with well-defined flavour which acting as dedicated hardware server

@ASawwaf
Copy link
Collaborator

ASawwaf commented Jul 7, 2019

the above is for Instance

for instance type:
Describes the parameters of the various virtual machine images that are available to users; includes parameters such as CPU, storage, and memory. Alternative term for flavor.

Copy link
Collaborator

@bfcohen bfcohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that vAPP is not standard terminology. I am OK with using VA (virtual application) we are kind of in uncharted territory and need to create some standard terminology, and that is OK.

@karinesevilla
Copy link
Collaborator

@pgoyal01, @rabiabdel
Agree to move the definitions of instance type and compute flavours a level above.
Instance type must be independent of VM, we should replace VM by VNFC -> the type of NFVI on which VNFC is expected to run on.

@rabiabdel
Copy link
Collaborator

Hi @pgoyal01 can we please replace the sentence "physical compute server" in both instance type and compute flavour with "NFVI". Thanks

Copy link
Collaborator

@rabiabdel rabiabdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the above is for Instance

for instance type:
Describes the parameters of the various virtual machine images that are available to users; includes parameters such as CPU, storage, and memory. Alternative term for flavor.

Hi @ASawwaf : instance type is not an alternative to flavour. it is a completely different term.

- **compute flavour**: defines the compute, memory, and storage capacity of a virtual compute resource.
>_*Note:*_ a **VM** consists of all of the components (processor (CPU), memory, storage, interfaces/ports, etc.) of a physical computer/server. It is created using Instance Type together with sizing information or Compute Flavour.
- **VM Instance**: is a VM
- **Instance type**: defines the capabilities of the physical compute server that the virtual compute resource can run on.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pgoyal01 can we please replace the sentence "physical compute server" in both instance type and compute flavour with "NFVI". Thanks

@ASawwaf
Copy link
Collaborator

ASawwaf commented Jul 8, 2019

@rabiaabdel, Just maybe it used interchangeably but OpenStack guys :) , also this is from openstack.org definition

Defined the terms Instance Type and Instance:

Instance Type; defines the capabilities of an image available to users for the creation of a virtual compute resource; includes capabilities such as CPU, storage, and memory.

Instance: is a virtual compute resource, in a known state such as running or suspended, that can be used like a physical server. NOTE: can be used to specify VM Instance or Container Instance.
@rabiabdel
Copy link
Collaborator

rabiabdel commented Jul 8, 2019

Hi @pgoyal01: i am not sure the relevance of an image here.

can you please revert the terminology for instance type and instance to the original definition (as it seems it is the one we agree on here). it will be great if we can get this approved tomorrow.

Changed definition of Instance Type:
Instance type: specifies a set of virtualized hardware resources and capabilities used for the creation of a virtual compute on which a workload runs on; includes capability specifications such as CPU, storage, and memory.

It is more in line with multiple versions:
Google: A machine type is a set of virtualized hardware resources available to a virtual machine (VM) instance, including the system memory size, virtual CPU (vCPU) count, and persistent disk limits.
 
AWS: Instance Types. When you launch an instance, the instance type that you specify determines the hardware of the host computer used for your instance. ... Amazon EC2 dedicates some resources of the host computer, such as CPU, memory, and instance storage, to a particular instance.

OpenStack: Instance Type: Describes the parameters of the various virtual machine images that are available to users; includes parameters such as CPU, storage, and memory. Alternative term for flavor.
@markshostak
Copy link
Collaborator

Approved 9/7/2019 as written

Copy link
Collaborator

@rabiabdel rabiabdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on 9th July 2019

@rabiabdel rabiabdel merged commit d56d69f into anuket-project:master Jul 9, 2019
@pgoyal01 pgoyal01 deleted the patch-9 branch July 12, 2019 13:45
@rabi-abdel rabi-abdel added the Archive Archive Item label Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Archive Archive Item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants