Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter06 (cleanup) #70

Merged
merged 13 commits into from
Jul 14, 2019
Merged

Chapter06 (cleanup) #70

merged 13 commits into from
Jul 14, 2019

Conversation

pgoyal01
Copy link
Collaborator

@pgoyal01 pgoyal01 commented Jul 9, 2019

Made changes to the Text. Other changes to follow once can get the new figure uploaded.

Made changes to the Text. Other changes to follow once can get the new figure uploaded.
Chapter 6 Figure showing relationship between HW profiles, SW Flaours, Physical servers, etc.
Added a diagram and accompanying text; adjusted figure and section numbers.

Still need to correct Figure 6-1 to be borrowed from Chapter 5.
Added the correct figure. During merge may have to change path name.
@karinesevilla
Copy link
Collaborator

@pgoyal01
Hi Pankaj
The image corresponding to figure 6.1 is wrong, it's SW profile and not HW.

chap6_figure6_1_Hw_profile

@karinesevilla
Copy link
Collaborator

It should be the image sent with my previous comment

@rabiabdel
Copy link
Collaborator

@pgoyal01 Please fix as per @karinesevilla comment.

@rabiabdel rabiabdel changed the title Update Chapter06.md Chapter06 (cleanup) Jul 11, 2019
@BernardTsai-DT
Copy link
Collaborator

In the diagram doc/ref_model/figures/Chapter-6-HW-SW-Profile-Diagram.png it would be great if we would not only refer to compute but also to network and storage resources. So would it be possible to have as a caption in the orange box: Virtual Infrastructure Resource

@pgoyal01
Copy link
Collaborator Author

pgoyal01 commented Jul 11, 2019 via email

Changed one of the diagrams
Update Chapter6-HW-SW-Profile Diagram
@pgoyal01
Copy link
Collaborator Author

Bernard,
Incorporated your request.

@rabiabdel
Copy link
Collaborator

rabiabdel commented Jul 12, 2019

Update diagram as per discussion. once updated, it will be approved and merged. @karinesevilla to confirm once updated.

Made changes to Figure 6-1, verbiage around "host profile" to clarify scope and resultant changes.
@pgoyal01 pgoyal01 requested a review from rabiabdel as a code owner July 13, 2019 18:13
@rabiabdel
Copy link
Collaborator

@pgoyal01: let me know once you done with this Pull Request, i will merge once you ready. i am assuming you and @karinesevilla agreed on this diagram, right?

Added reference to EPA
@pgoyal01
Copy link
Collaborator Author

Rabi,
Had a number of exchanges primarily with Xavier on Friday. I think, at a minimum, Karine and Xavier should review both the diagram and the content changes; other should too but Xavier had important insights.

@rabiabdel
Copy link
Collaborator

@karinesevilla @xavier-grall can you both please review this and let me know if you are happy with it? we need to get this done ASAP. Thanks

@rabiabdel rabiabdel mentioned this pull request Jul 14, 2019
@rabiabdel
Copy link
Collaborator

for sake of time, i will approve it and merge it. in case any more changes needed by @karinesevilla @xavier-grall, we can reflect them in the release cleanup Pull Request #101

@rabiabdel rabiabdel merged commit 3cfd7f5 into anuket-project:master Jul 14, 2019
@rabi-abdel rabi-abdel added the Archive Archive Item label Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Archive Archive Item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants